[MWRAPPER-111] Trim whitespace when reading from properties file #158
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slachiewicz
approved these changes
Dec 14, 2024
Contributor
Author
|
Thanks @slachiewicz ! |
|
Resolve #307 |
1 similar comment
|
Resolve #307 |
slawekjaranowski
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue: https://issues.apache.org/jira/projects/MWRAPPER/issues/MWRAPPER-111
This PR trims the values read from the property files by removing whitespace such as newlines.
This has already be done in the case of
maven-wrapper-distribution/src/resources/only-mvnw, but it's missing frommaven-wrapper-distribution/src/resources/mvnw.With this change, validating the wrapper checksum no longer fails if the property file has CLRF line endings.