Add convinient method to check for the currently used Java Version #120
Conversation
britter
force-pushed
the
assume-java-version
branch
from
ff951f9 to
70ffbd4
Compare
|
|
||
| public static void assumeJavaVersion(JavaVersion version) | ||
| { | ||
| assumeThat( "java.specification.version: ", |
There was a problem hiding this comment.
Nice PR. Maybe SystemUtils.JAVA_SPECIFICATION_VERSION + ": instead. Do you like static imports?
There was a problem hiding this comment.
Hey Tibor,
do you mean to use a constant instead of the string in the message part of assumeThat? There is no constant for the property name in Commons Lang. But I could introduce one in HelperAssertions or we could extend SystemUtils, but then we have to wait for the next release of Commons Lang.
There was a problem hiding this comment.
I've added the static import.
britter
force-pushed
the
assume-java-version
branch
from
8a854ef to
498942b
Compare
|
Hello @Tibor17 I've addressed you're comment about comparing Strings. There already is an API for comparing JavaVersions in SystemUtils. Hope you like this. |
| assumeThat( "java.specification.version: ", | ||
| JAVA_SPECIFICATION_VERSION, is( greaterThanOrEqualTo( version.toString() ) ) ); | ||
| assumeTrue( "java.specification.version: " + JAVA_SPECIFICATION_VERSION, | ||
| SystemUtils.isJavaVersionAtLeast( version ) ); |
There was a problem hiding this comment.
Yes this is cool. Thx.
I will come back to your PRs soon.
There was a problem hiding this comment.
I am running the build mvn install -Prun-its, let's wait for the result.
|
@britter |
|
@britter |
|
@Tibor17 thank you for integrating this. Did you know, that it is possible to mark PRs as merged in GitHub? I've documented the workflow in the Apache Commons Wiki. |
I don't see such option in GUI. Is not it because of we are not the owner of this repo |
|
Resolve #2402 |
3 participants
No description provided.