[SUREFIRE-2152] Include display-name of JUnit5 templated-tests in methodDesc

This includes the displayName (e.g. value of name="..." of a
@ParameterizedTest) in the method description / test identifier.

Provides more information than merely the invocation ID in case
of failing tests, also for the console reporter. This can
(especially if the actual list of arguments are quite large and/or
dynamically determined at runtime) help a lot to identify which
actual cases are the problematic ones.

Author: s-rwe

surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java

@@ -374,6 +374,9 @@ private String[] toClassMethodName( TestIdentifier testIdentifier )
 
             // Override resulting methodDesc/methodDisp values again, for invocations of
             // JUnit5 templated-tests (such as @ParameterizedTest/@RepeatedTest)
+            // => Include the display-name of the actual invocation as well in the methodDesc of
+            //    each invocation (also according to the 'name=' values of such tests), to have
+            //    more context of what failed also e.g. from output of console reporter
             Integer templatedTestInvocationId = extractTemplatedInvocationId( testIdentifier );
             if ( templatedTestInvocationId != null )
             {
@@ -384,8 +387,14 @@ private String[] toClassMethodName( TestIdentifier testIdentifier )
                 String methodSignature = methodName + '(' + simpleClassNames + ')';
 
                 String invocationIdStr = "[" + templatedTestInvocationId + "]";
-
-                methodDesc = methodSignature + invocationIdStr;
+                String displayForDesc = display;
+                if ( displayForDesc.startsWith( invocationIdStr ) )
+                {
+                    // a bit hacky, try to prevent including ID multiple times in most default cases
+                    // "foo()[1][1] abc def" -> "foo()[1] abc def"
+                    displayForDesc = displayForDesc.substring( invocationIdStr.length() );
+                }
+                methodDesc = methodSignature + invocationIdStr + displayForDesc;
                 methodDisp = parentDisplay + display;
             }