From 17aabccca1590f01925db9f63f04a67bd0a4c2f1 Mon Sep 17 00:00:00 2001 From: Tamas Cservenak Date: Thu, 12 Jan 2023 22:08:08 +0100 Subject: [PATCH] [MPLUGIN-452] Maven scope and module name logs at wrong level (#190) Should be logged at WARN level, and not ERROR level. When Mojo logs ERROR, it is expected that it fails the build. And this also confuses the Verifier. --- https://issues.apache.org/jira/browse/MPLUGIN-452 --- .../maven/plugin/plugin/DescriptorGeneratorMojo.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java b/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java index 0954a727..8b3fb142 100644 --- a/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java +++ b/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java @@ -253,7 +253,7 @@ public void generate() && project.getArtifactId().toLowerCase().endsWith( "-plugin" ) && !"org.apache.maven.plugins".equals( project.getGroupId() ) ) { - getLog().error( LS + LS + "Artifact Ids of the format maven-___-plugin are reserved for" + LS + getLog().warn( LS + LS + "Artifact Ids of the format maven-___-plugin are reserved for" + LS + "plugins in the Group Id org.apache.maven.plugins" + LS + "Please change your artifactId to the format ___-maven-plugin" + LS + "In the future this error will break the build." + LS + LS ); @@ -270,7 +270,7 @@ public void generate() Set wrongScopedArtifacts = dependenciesNotInProvidedScope(); if ( !wrongScopedArtifacts.isEmpty() ) { - StringBuilder errorMessage = new StringBuilder( + StringBuilder message = new StringBuilder( LS + LS + "Some dependencies of Maven Plugins are expected to be in provided scope." + LS + "Please make sure that dependencies listed below declared in POM" + LS + "have set 'provided' as well." + LS + LS @@ -278,11 +278,11 @@ public void generate() ); for ( Artifact artifact : wrongScopedArtifacts ) { - errorMessage.append( " * " ).append( artifact ).append( LS ); + message.append( " * " ).append( artifact ).append( LS ); } - errorMessage.append( LS ).append( LS ); + message.append( LS ).append( LS ); - getLog().error( errorMessage.toString() ); + getLog().warn( message.toString() ); } }