detectOfflineLinks is now false per default for all *jar* mojo issue #1258 #1259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
olamy
changed the title
Closed
elharo
reviewed
Aug 26, 2025
|
|
||
| /** | ||
| * Detect the links for all modules defined in the project. | ||
| * <br/> |
| * If {@code reactorProjects} is defined in a non-aggregator way, it generates default offline links | ||
| * between modules based on the defined project's urls. For instance, if a parent project has two projects | ||
| * <code>module1</code> and <code>module2</code>, the <code>-linkoffline</code> will be: | ||
| * <br/> |
src/main/java/org/apache/maven/plugins/javadoc/JavadocJarMojo.java
Outdated
Show resolved
Hide resolved
| * <br/> | ||
| * The added Javadoc <code>-linkoffline</code> parameter for <b>module1</b> will be | ||
| * <code>/absolute/path/to/</code><b>module2</b><code>/target/site/apidocs</code> | ||
| * <br/> |
| * @see #offlineLinks | ||
| * @since 2.6 | ||
| */ | ||
| @Parameter(property = "detectOfflineLinks", defaultValue = "false") |
There was a problem hiding this comment.
why is this here instead of the superclass?
There was a problem hiding this comment.
because the role of this change is to have a default of false for *jar* mojos and leave parent as true
Signed-off-by: Olivier Lamy <olamy@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olivier Lamy olamy@apache.org
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.