detectOfflineLinks is now false per default for all *jar* mojo issue #1258 (#1259)

* Issue #1258 make detectOfflineLinks false per default for jar mojo

---------

Signed-off-by: Olivier Lamy <olamy@apache.org>

Author: olamy

src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java

@@ -496,7 +496,7 @@ public AbstractJavadocMojo(
      * Detect the links for all modules defined in the project.
      * <br/>
      * If {@code reactorProjects} is defined in a non-aggregator way, it generates default offline links
-     * between modules based on the defined project's urls. For instance, if a parent project has two projects
+     * between modules based on the defined project's URLs. For instance, if a parent project has two projects
      * <code>module1</code> and <code>module2</code>, the <code>-linkoffline</code> will be:
      * <br/>
      * The added Javadoc <code>-linkoffline</code> parameter for <b>module1</b> will be
@@ -5331,6 +5331,10 @@ private String getFullJavadocGoal() {
         return sb.toString();
     }
 
+    protected boolean isDetectOfflineLinks() {
+        return detectOfflineLinks;
+    }
+
     /**
      * Using Maven, a Javadoc link is given by <code>${project.url}/apidocs</code>.
      *
@@ -5343,7 +5347,7 @@ private String getFullJavadocGoal() {
      */
     private List<OfflineLink> getModulesLinks() throws MavenReportException {
         List<MavenProject> aggregatedProjects = reactorProjects;
-        if (!detectOfflineLinks || isAggregator() || aggregatedProjects.isEmpty()) {
+        if (!isDetectOfflineLinks() || isAggregator() || aggregatedProjects.isEmpty()) {
             return Collections.emptyList();
         }
 

src/main/java/org/apache/maven/plugins/javadoc/JavadocJarMojo.java

@@ -176,6 +176,25 @@ public JavadocJarMojo(
     @Parameter(property = "maven.javadoc.classifier", defaultValue = "javadoc", required = true)
     private String classifier;
 
+    /**
+     * Detect the links for all modules defined in the project.
+     * <br/>
+     * If {@code reactorProjects} is defined in a non-aggregator way, it generates default offline links
+     * between modules based on the defined project's URLs. For instance, if a parent project has two projects
+     * <code>module1</code> and <code>module2</code>, the <code>-linkoffline</code> will be:
+     * <br/>
+     * The added Javadoc <code>-linkoffline</code> parameter for <b>module1</b> will be
+     * <code>/absolute/path/to/</code><b>module2</b><code>/target/site/apidocs</code>
+     * <br/>
+     * The added Javadoc <code>-linkoffline</code> parameter for <b>module2</b> will be
+     * <code>/absolute/path/to/</code><b>module1</b><code>/target/site/apidocs</code>
+     *
+     * @see #offlineLinks
+     * @since 2.6
+     */
+    @Parameter(property = "detectOfflineLinks", defaultValue = "false")
+    private boolean detectOfflineLinks;
+
     /** {@inheritDoc} */
     @Override
     protected void doExecute() throws MojoExecutionException {
@@ -290,4 +309,9 @@ private File generateArchive(File javadocFiles, String jarFileName) throws Archi
 
         return outputFile;
     }
+
+    @Override
+    public boolean isDetectOfflineLinks() {
+        return detectOfflineLinks;
+    }
 }