chore: remove junit3 references (#487)

* chore: remove junit3 references

also update surefire version in it-tests

* refactor: replace hardcoded surefire version by property

Author: sparsick

pom.xml

@@ -237,6 +237,9 @@
                 <goal>package</goal>
               </goals>
               <showErrors>true</showErrors>
+              <filterProperties>
+                <pluginPropertyUsedForFiltering>version.maven-surefire</pluginPropertyUsedForFiltering>
+              </filterProperties>
             </configuration>
             <executions>
               <execution>

src/it/MJAR-30-excludes/pom.xml

@@ -25,14 +25,6 @@
   <packaging>jar</packaging>
   <name>Maven</name>
   <description>Tests excludes.</description>
-  <dependencies>
-    <dependency>
-      <groupId>junit</groupId>
-      <artifactId>junit</artifactId>
-      <version>3.8.1</version>
-      <scope>test</scope>
-    </dependency>
-  </dependencies>
   <build>
     <plugins>
       <plugin>
@@ -48,7 +40,7 @@
       </plugin>
       <plugin>
         <artifactId>maven-surefire-plugin</artifactId>
-        <version>2.3</version>
+        <version>@version.maven-surefire@</version>
       </plugin>
     </plugins>
   </build>

src/it/MJAR-30-excludes/src/test/java/foo/project003/AppTest.java

@@ -26,14 +26,6 @@
   <name>Maven</name>
   <description>Tests the normal behavior of jar-plugin.</description>
   <url>http://maven.apache.org</url>
-  <dependencies>
-    <dependency>
-      <groupId>junit</groupId>
-      <artifactId>junit</artifactId>
-      <version>3.8.1</version>
-      <scope>test</scope>
-    </dependency>
-  </dependencies>
   <build>
     <plugins>
       <plugin>
@@ -43,7 +35,7 @@
       </plugin>
       <plugin>
         <artifactId>maven-surefire-plugin</artifactId>
-        <version>2.3</version>
+        <version>@version.maven-surefire@</version>
       </plugin>
     </plugins>
   </build>

src/it/MJAR-30-excludes/src/test/resources/excluded-file.txt

@@ -40,7 +40,7 @@ under the License.
       </plugin>
       <plugin>
         <artifactId>maven-surefire-plugin</artifactId>
-        <version>2.3</version>
+        <version>@version.maven-surefire@</version>
       </plugin>
     </plugins>
   </build>

src/it/MJAR-30-excludes/src/test/resources/test-default-configuration.properties

@@ -25,14 +25,6 @@
   <packaging>jar</packaging>
   <name>Maven</name>
   <description>Tests excludes.</description>
-  <dependencies>
-    <dependency>
-      <groupId>junit</groupId>
-      <artifactId>junit</artifactId>
-      <version>3.8.1</version>
-      <scope>test</scope>
-    </dependency>
-  </dependencies>
   <build>
     <plugins>
       <plugin>
@@ -55,7 +47,7 @@
       </plugin>
       <plugin>
         <artifactId>maven-surefire-plugin</artifactId>
-        <version>2.3</version>
+        <version>@version.maven-surefire@</version>
       </plugin>
     </plugins>
   </build>