Fix [MDEP-931] Replace PrintWriter with Writer in AbstractSerializing Visitor and subclasses #530

Ndacyayisenga-droid · 2025-05-20T13:44:27Z

Following this checklist to help us incorporate your
contribution quickly and easily:

Fixes https://issues.apache.org/jira/browse/MDEP-931

Your pull request should address just one issue, without pulling in other changes.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Each commit in the pull request should have a meaningful subject line and body.
Note that commits might be squashed by a maintainer on merge.
Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
Run mvn verify to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.

src/main/java/org/apache/maven/plugins/dependency/tree/DOTDependencyNodeVisitor.java

src/main/java/org/apache/maven/plugins/dependency/tree/GraphmlDependencyNodeVisitor.java

src/main/java/org/apache/maven/plugins/dependency/tree/JsonDependencyNodeVisitor.java

src/main/java/org/apache/maven/plugins/dependency/tree/TGFDependencyNodeVisitor.java

src/main/java/org/apache/maven/plugins/dependency/tree/DOTDependencyNodeVisitor.java

src/main/java/org/apache/maven/plugins/dependency/tree/GraphmlDependencyNodeVisitor.java

src/main/java/org/apache/maven/plugins/dependency/tree/JsonDependencyNodeVisitor.java

elharo · 2025-05-30T17:41:00Z

CI failing on a known flaky test:

Error:  Failures: 
Error:    TestUnpackMojo.testUnpackOverWriteIfNewer:513 unpackedFile '/var/folders/tp/bfmjfn9s0hd59bm9z80j3mgm0000gn/T/unpack2709761897097392486/outputDirectory/testGroupId-snapshot-2.0-SNAPSHOT-null-jar.txt' lastModified() == 1748599196000: should be different. Actual: 1748599196000
[INFO]

jira-importer · 2025-06-18T08:09:34Z

Resolve #1439

…Visitor and subclasses Replace PrintWriter with Writer in AbstractSerializing Visitor and subclasses Only use writer

Ndacyayisenga-droid · 2025-06-30T13:53:06Z

@elharo I droped all the stringwiters and wrote straight onto the writer

elharo · 2025-06-30T14:45:44Z

src/main/java/org/apache/maven/plugins/dependency/tree/JsonDependencyNodeVisitor.java

-        if (node.getParent() == null || node.getParent() == node) {
-            writeRootNode(node);
+        try {
+            if (node.getParent() == null || node.getParent() == node) {


This is weird. Nodes can be their own parent?

src/main/java/org/apache/maven/plugins/dependency/tree/TGFDependencyNodeVisitor.java

src/main/java/org/apache/maven/plugins/dependency/tree/DOTDependencyNodeVisitor.java

src/main/java/org/apache/maven/plugins/dependency/tree/GraphmlDependencyNodeVisitor.java

src/main/java/org/apache/maven/plugins/dependency/tree/TGFDependencyNodeVisitor.java

slawekjaranowski

there are more place to use System.lineSeparator

github-actions · 2025-08-10T13:08:31Z

@slawekjaranowski Please assign appropriate label to PR according to the type of change.

elharo requested changes May 27, 2025

View reviewed changes

Ndacyayisenga-droid requested a review from elharo May 30, 2025 00:00

elharo requested changes May 30, 2025

View reviewed changes

Fix [MDEP-931] Replace PrintWriter with Writer in AbstractSerializing…

da1730c

…Visitor and subclasses Replace PrintWriter with Writer in AbstractSerializing Visitor and subclasses Only use writer

Ndacyayisenga-droid force-pushed the MDEP-931 branch from 018c0d1 to da1730c Compare June 30, 2025 13:49

Ndacyayisenga-droid requested a review from elharo June 30, 2025 13:53

elharo approved these changes Jun 30, 2025

View reviewed changes

slawekjaranowski requested changes Jul 6, 2025

View reviewed changes

src/main/java/org/apache/maven/plugins/dependency/tree/TGFDependencyNodeVisitor.java Outdated Show resolved Hide resolved

use System.lineSeparator

eb50b47

Ndacyayisenga-droid requested a review from slawekjaranowski July 10, 2025 11:28