Avoid deprecated ArtifactFactory #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawekjaranowski
approved these changes
Jan 6, 2025
| assertTrue(baseDirectory.isDirectory()); | ||
|
|
||
| org.apache.maven.repository.RepositorySystem repositorySystem = | ||
| lookup(org.apache.maven.repository.RepositorySystem.class); |
There was a problem hiding this comment.
grr org.apache.maven.repository.RepositorySystem is also deprecated , it has only Legacy implementation ... 😄
There was a problem hiding this comment.
Bleah, still trying to figure out what needs to be done for these sorts of thing. It would be too easy if whoever deprecated this way back when had documented the replacement.
There was a problem hiding this comment.
😄 our deprecated code is not well documented ...
In this case you can simply use new DefaultArtifact(....)
elharo
added
the
skip-changelog
slawekjaranowski
removed
the
skip-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.