[MDEP-900] dependency:resolve fails for multi-module project

[michael-o]

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [MDEP-XXX] - Fixes bug in ApproximateQuantiles,
  where you replace MDEP-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the
  commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean verify to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[michael-o]

This one lacks a test...

[michael-o]

@slawekjaranowski Can we use the IT from #349?

[slawekjaranowski]

ups existing tests failed ...

[michael-o]

ups existing tests failed ...

I am running locally, will report...

[michael-o]

I have the reason and the reason is valid and I believe that 0bb4c59 must be reverted.
The goal is called resolve, the other one should have been called resolve-sources. The source code clearly says:

            // dependencies:collect won't download jars
            if (artifact.getFile() != null) {
                ModuleDescriptor moduleDescriptor = getModuleDescriptor(artifact.getFile());
                if (moduleDescriptor != null) {
                    messageBuilder.project(" -- module " + moduleDescriptor.name);

                    if (moduleDescriptor.automatic) {
                        if ("MANIFEST".equals(moduleDescriptor.moduleNameSource)) {
                            messageBuilder.strong(" [auto]");
                        } else {
                            messageBuilder.warning(" (auto)");
                        }
                    }
                }
            }

So we need collect-sources maybe as well. I am inclined to close MDEP-900 as wontfix and revert MDEP-895.

[slawekjaranowski]

...
So we need collect-sources maybe as well. I am inclined to close MDEP-900 as wontfix and revert MDEP-895.

@michael-o I checked again .... you are right here ... if we have a resolve-xxx mojo dependencies should be resolved

There can be a bug in maven-artifact-transfer ... during build list of dependenies
I working step by step to get rid of ot

[michael-o]

...
So we need collect-sources maybe as well. I am inclined to close MDEP-900 as wontfix and revert MDEP-895.

@michael-o I checked again .... you are right here ... if we have a resolve-xxx mojo dependencies should be resolved

There can be a bug in maven-artifact-transfer ... during build list of dependenies I working step by step to get rid of ot

I'd say the first we should revert MDEP-895 and the have a look at your idea. Both tickets should remain open for the time being.

[michael-o]

Revert is here: #408

[michael-o]

Closing this experiment, leaving the branch.

[jira-importer]

Resolve #1409