[MCOMPILER-538] Do not add target/generated-sources/annotations to the source roots #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mensinda
changed the title
mensinda
force-pushed
the
optionalGeneratedSources
branch
from
1fb1448
to
a47f454
Compare
elharo
changed the title
elharo
requested changes
Dec 17, 2023
|
I have been checking the javac options, and testing with this change, it does seem that we don't need to specify the generated-sources/annotations in the -sourcepath argument, it should be more than enough to specify it on the -s option. |
slawekjaranowski
requested changes
Dec 20, 2023
|
All my projects that test upgrades to 3.12.0 fail because of this line, looking forward to when it's removed! |
@Nthalk We need more details. There is a version 3.12.1 under vote, will be available in a few day. |
I'm using renovate for auto dependency upgrades on multiple projects, the simplest doesn't use any annotation processing and yields this error on The configuration I have is pretty simple, no funny business: Here is the output of |
|
@Nthalk version 3.12.1 is going to be released in a couple of days fixing that issue. |
mensinda
force-pushed
the
optionalGeneratedSources
branch
from
a47f454
to
5910df7
Compare
|
I have rebased the PR and added a test case. I am not really happy with the hardcoded paths in |
mensinda
force-pushed
the
optionalGeneratedSources
branch
from
5910df7
to
9b86939
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for MCOMPILER-538.
The
generatedSourcesPathwill still be added to the maven project paths.Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MCOMPILER-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.