Skip to content

Commit d86043e

Browse files
committed
[MCHECKSTYLE-445] Upgrade to Doxia 2.0.0 Milestone Stack
This closes #114
1 parent d5d15de commit d86043e

File tree

25 files changed

+116
-130
lines changed

25 files changed

+116
-130
lines changed

pom.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,10 @@ under the License.
7777
<aetherVersion>1.0.0.v20140518</aetherVersion>
7878
<mavenVersion>3.2.5</mavenVersion>
7979
<checkstyleVersion>9.3</checkstyleVersion>
80-
<doxiaVersion>1.11.1</doxiaVersion>
81-
<doxiaSitetoolsVersion>1.11.1</doxiaSitetoolsVersion>
82-
<sitePluginVersion>3.12.1</sitePluginVersion>
83-
<jxrPluginVersion>3.3.0</jxrPluginVersion>
80+
<doxiaVersion>2.0.0-M12</doxiaVersion>
81+
<doxiaSitetoolsVersion>2.0.0-M19</doxiaSitetoolsVersion>
82+
<sitePluginVersion>4.0.0-M15</sitePluginVersion>
83+
<jxrPluginVersion>4.0.0-M1-SNAPSHOT</jxrPluginVersion>
8484
<project.build.outputTimestamp>2023-10-21T10:39:27Z</project.build.outputTimestamp>
8585
</properties>
8686

@@ -125,12 +125,12 @@ under the License.
125125
<dependency>
126126
<groupId>org.apache.maven.reporting</groupId>
127127
<artifactId>maven-reporting-api</artifactId>
128-
<version>3.1.1</version>
128+
<version>4.0.0-M12</version>
129129
</dependency>
130130
<dependency>
131131
<groupId>org.apache.maven.reporting</groupId>
132132
<artifactId>maven-reporting-impl</artifactId>
133-
<version>3.2.0</version>
133+
<version>4.0.0-M15</version>
134134
</dependency>
135135

136136
<!-- doxia -->

src/it/MCHECKSTYLE-222-resources/verify.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@
1717
* under the License.
1818
*/
1919

20-
assert new File(basedir, 'target/site/checkstyle.html').exists();
20+
assert new File(basedir, 'target/reports/checkstyle.html').exists();
2121

2222
return true;

src/it/MCHECKSTYLE-222-testResources/verify.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@
1717
* under the License.
1818
*/
1919

20-
assert new File(basedir, 'target/site/checkstyle.html').exists();
20+
assert new File(basedir, 'target/reports/checkstyle.html').exists();
2121

2222
return true;

src/it/MCHECKSTYLE-338/verify.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ assert buildLog.text.contains( 'EmptyLogging: EmptyLoggingCheck on file TestFals
2525
assert !buildLog.text.contains( 'EmptyLogging: EmptyLoggingCheck on file TestTrue.java' )
2626

2727
// verify that the "checkstyle" goal does the same
28-
site = new File( basedir, 'omitignoredmodules-false/target/site/checkstyle.html' )
28+
site = new File( basedir, 'omitignoredmodules-false/target/reports/checkstyle.html' )
2929
assert site.text.contains( 'EmptyLoggingCheck on file TestFalse.java' )
30-
site = new File( basedir, 'omitignoredmodules-true/target/site/checkstyle.html' )
30+
site = new File( basedir, 'omitignoredmodules-true/target/reports/checkstyle.html' )
3131
assert !site.text.contains( 'EmptyLoggingCheck on file TestTrue.java' )

src/it/MCHECKSTYLE-412/src/main/java/org/MyClass.java

Lines changed: 0 additions & 26 deletions
This file was deleted.

src/it/MCHECKSTYLE-99-custom-xref-test-location/verify.groovy

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@
1818
* under the License.
1919
*/
2020

21-
site = new File( basedir, 'target/site/checkstyle.html' )
22-
assert site.exists();
23-
assert site.text.contains( '<a href="./xref/com/example/App.html#L26">' )
24-
assert site.text.contains( '<a href="./custom-xref-test-location/com/example/AppTest.html#L32">' )
21+
report = new File( basedir, 'target/reports/checkstyle.html' )
22+
assert report.exists();
23+
assert report.text.contains( '<a href="./xref/com/example/App.html#L26">' )
24+
assert report.text.contains( '<a href="./custom-xref-test-location/com/example/AppTest.html#L32">' )
2525

2626
return true;

src/it/MCHECKSTYLE-99/verify.groovy

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@
1818
* under the License.
1919
*/
2020

21-
site = new File( basedir, 'target/site/checkstyle.html' )
22-
assert site.exists();
23-
assert site.text.contains( '<a href="./xref/com/example/App.html#L26">' )
24-
assert site.text.contains( '<a href="./xref-test/com/example/AppTest.html#L32">' )
21+
report = new File( basedir, 'target/reports/checkstyle.html' )
22+
assert report.exists();
23+
assert report.text.contains( '<a href="./xref/com/example/App.html#L26">' )
24+
assert report.text.contains( '<a href="./xref-test/com/example/AppTest.html#L32">' )
2525

2626
return true;

src/it/checkstyle-goal/verify.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ assert new File( basedir, 'target/checkstyle-checker.xml' ).exists();
2424
assert new File( basedir, 'target/checkstyle-header.txt' ).exists();
2525
assert new File( basedir, 'target/checkstyle-result.xml' ).exists();
2626

27-
def html = new File( basedir, 'target/site/checkstyle.html' ).text;
27+
def html = new File( basedir, 'target/reports/checkstyle.html' ).text;
2828
assert html.contains( '<meta charset="UTF-8" />' );
2929

3030
return true;

src/main/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleReport.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
import org.apache.maven.plugins.checkstyle.exec.CheckstyleExecutorException;
5050
import org.apache.maven.plugins.checkstyle.exec.CheckstyleExecutorRequest;
5151
import org.apache.maven.plugins.checkstyle.exec.CheckstyleResults;
52+
import org.apache.maven.project.MavenProject;
5253
import org.apache.maven.reporting.AbstractMavenReport;
5354
import org.apache.maven.reporting.MavenReportException;
5455
import org.codehaus.plexus.configuration.PlexusConfiguration;
@@ -473,6 +474,14 @@ protected String getI18nString(Locale locale, String key) {
473474
return i18n.getString("checkstyle-report", locale, "report.checkstyle." + key);
474475
}
475476

477+
protected MavenProject getProject() {
478+
return project;
479+
}
480+
481+
protected List<MavenProject> getReactorProjects() {
482+
return reactorProjects;
483+
}
484+
476485
/** {@inheritDoc} */
477486
public void executeReport(Locale locale) throws MavenReportException {
478487
checkDeprecatedParameterUsage(sourceDirectory, "sourceDirectory", "sourceDirectories");

src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleAggregateReport.java

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,9 @@
1818
*/
1919
package org.apache.maven.plugins.checkstyle;
2020

21-
import java.util.List;
22-
2321
import org.apache.maven.plugins.annotations.Mojo;
24-
import org.apache.maven.plugins.annotations.Parameter;
2522
import org.apache.maven.plugins.annotations.ResolutionScope;
2623
import org.apache.maven.plugins.checkstyle.exec.CheckstyleExecutorRequest;
27-
import org.apache.maven.project.MavenProject;
2824
import org.apache.maven.reporting.MavenReportException;
2925

3026
/**
@@ -40,19 +36,6 @@
4036
requiresDependencyResolution = ResolutionScope.COMPILE,
4137
threadSafe = true)
4238
public class CheckstyleAggregateReport extends AbstractCheckstyleReport {
43-
/**
44-
* The projects in the reactor for aggregation report.
45-
*
46-
* @since 2.8
47-
*/
48-
@Parameter(property = "reactorProjects", readonly = true)
49-
private List<MavenProject> reactorProjects;
50-
51-
/** {@inheritDoc} */
52-
protected MavenProject getProject() {
53-
return project;
54-
}
55-
5639
/**
5740
* {@inheritDoc}
5841
*/

0 commit comments

Comments
 (0)