Commit b61ef66
committed
Address PR review comments
- Change LOGGER.error to LOGGER.warn for unknown parameter validation
Unknown parameters may legitimately occur when users manually correct
outdated bundled configs, so warning level is more appropriate.
- Use ConcurrentHashMap instead of HashMap in PluginParameterLoader
Ensures thread safety in multi-threaded Maven builds where the cache
may be accessed from different worker threads.
Addresses review comments from:
- #389 (review)
- #389 (review)1 parent 4b1679f commit b61ef66
File tree
2 files changed
+3
-3
lines changed- src/main/java/org/apache/maven/buildcache/xml
2 files changed
+3
-3
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
334 | 334 | | |
335 | 335 | | |
336 | 336 | | |
337 | | - | |
| 337 | + | |
338 | 338 | | |
339 | 339 | | |
340 | 340 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
26 | 25 | | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| |||
0 commit comments