Skip to content

Simplify Velocity conditional for JUnit BOM dependency management#136

Open
behrangsa wants to merge 2 commits into
apache:masterfrom
behrangsa:master
Open

Simplify Velocity conditional for JUnit BOM dependency management#136
behrangsa wants to merge 2 commits into
apache:masterfrom
behrangsa:master

Conversation

@behrangsa
Copy link
Copy Markdown

@behrangsa behrangsa commented Feb 27, 2026

Replace #elseif version check with #else to apply JUnit BOM dependencyManagement for all non-JUnit 4 versions.

This change, makes the if conditions closer to and more consistent with archetype-resources/src/test/java/AppTest.java:

    #if ( $junitVersion == $null || $junitVersion.startsWith("4."))

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Addresses #128

Replace #elseif version check with #else to apply JUnit BOM
dependencyManagement for all non-JUnit 4 versions.

This change, makes the if conditions closer to and more consistent
with archetype-resources/src/test/java/AppTest.java:

```
    #if ( $junitVersion == $null || $junitVersion.startsWith("4."))
```
Add reference project and archetype properties for testing the
quickstart archetype with Java 25 and JUnit 6.0.3.
@behrangsa
Copy link
Copy Markdown
Author

I had previously signed the Apache Individual Contributor License Agreement when I contributed a PR to commons-io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant