Skip to content

Commit d17a264

Browse files
authored
Reserve LuceneDev6001-6003 and add initial entries for string/span/char analyzer rules (#13)
* Reserve LuceneDev6001-6003 and add initial entries for string/span/char analyzer rules * Reserve LuceneDev6001-6003 and add initial entries for string/span/char analyzer rules * fix: correct table format in AnalyzerReleases.Unshipped.md to resolve build warning
1 parent df79b0d commit d17a264

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

DiagnosticCategoryAndIdRanges.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,16 @@
1111
# 4. Your rule ID is now reserved and can be used in your PR.
1212
#
1313
# In the event of conflict in step 3, make sure you discard your changes, pull latest, and try again.
14-
# DO NOT remove ID ranges already defined or merge this file in git.
14+
# DO NOT remove ID ranges already defined or merge this file in git.
1515
#
1616
Design: LuceneDev1000-LuceneDev1008
1717
Globalization:
1818
Mobility:
1919
Performance:
2020
Security:
21-
Usage: LuceneDev6000
21+
Usage: LuceneDev6000-LuceneDev6003
2222
Naming:
2323
Interoperability:
24-
Maintainability:
24+
Maintainability:
2525
Reliability:
2626
Documentation:
Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
### New Rules
22

3-
Rule ID | Category | Severity | Notes
4-
---------------|----------|----------|-----------------------------------------------------------------------------------------------------------------------------------------------------------
5-
LuceneDev1007 | Design | Warning | Generic Dictionary<TKey, TValue> indexer should not be used to retrieve values because it may throw KeyNotFoundException (value type value)
6-
LuceneDev1008 | Design | Warning | Generic Dictionary<TKey, TValue> indexer should not be used to retrieve values because it may throw KeyNotFoundException (reference type value)
7-
LuceneDev6000 | Usage | Info | IDictionary indexer may be used to retrieve values, but must be checked for null before using the value
3+
Rule ID | Category | Severity | Notes
4+
--------------|----------|----------|-----------------------------------------------------------------------------------------------------------------------------------------------------------
5+
LuceneDev1007 | Design | Warning | Generic Dictionary<TKey, TValue> indexer should not be used to retrieve values because it may throw KeyNotFoundException (value type value)
6+
LuceneDev1008 | Design | Warning | Generic Dictionary<TKey, TValue> indexer should not be used to retrieve values because it may throw KeyNotFoundException (reference type value)
7+
LuceneDev6000 | Usage | Info | IDictionary indexer may be used to retrieve values, but must be checked for null before using the value
8+
LuceneDev6001 | Usage | Error | String overloads of StartsWith/EndsWith/IndexOf/LastIndexOf must be called with StringComparison.Ordinal or StringComparison.OrdinalIgnoreCase
9+
LuceneDev6002 | Usage | Warning | Span overloads of StartsWith/EndsWith/IndexOf/LastIndexOf should not pass non-Ordinal StringComparison
10+
LuceneDev6003 | Usage | Info | Single-character string arguments should use the char overload of StartsWith/EndsWith/IndexOf/LastIndexOf instead of a string

0 commit comments

Comments
 (0)