Add tests for regression in file rolling and fix bug #257
+325
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdziadkiewicz
changed the title
Flohack74
reviewed
Jun 24, 2025
|
|
||
| directory = Path.GetDirectoryName(fullPath); | ||
| if (Directory.Exists(directory)) | ||
| { | ||
| string baseFileName = Path.GetFileName(fullPath); | ||
|
|
||
There was a problem hiding this comment.
You might want to clean that whitespace change.
There was a problem hiding this comment.
Will do, thanks!
gdziadkiewicz
force-pushed
the
Fix_#250_and_add_tests_agains_regression_in_file_roll
branch
from
48ef9aa to
d77af80
Compare
gdziadkiewicz
force-pushed
the
Fix_#250_and_add_tests_agains_regression_in_file_roll
branch
from
b5db4fe to
783b998
Compare
gdziadkiewicz
force-pushed
the
Fix_#250_and_add_tests_agains_regression_in_file_roll
branch
from
783b998 to
6f9363c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #250
Problem
It is easy to break someone's legitimate Log4net configuration or not account for .NET version quirks while making changes to the rolling appended.
Idea
Gather all of the configurations we gathered in bug reports, plus variations that make sense for us, and use them as test cases against regression.
Remember:
TODO: