Reopen log file when rollover is unsuccessful #3226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppkarwasz
requested changes
Nov 21, 2024
There was a problem hiding this comment.
Thank you for your PR. It certainly solves the #2592 issue, but I would take the opportunity to clarify some RollingFileManager code.
IMHO, the code of the rolling file appenders is very unclear and hard to maintain, which is the cause of the multitude of bug reports for this component.
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/RollingFileManager.java
Outdated
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/RollingFileManager.java
Outdated
Show resolved
Hide resolved
...est/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingFileManagerTest.java
Show resolved
Hide resolved
...est/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingFileManagerTest.java
Outdated
Show resolved
Hide resolved
ppkarwasz
approved these changes
Nov 21, 2024
Generated by gradle/develocity-actions |
|
Thank You for your contribution! 💯 |
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2592
Fixes
RollingFileManagerto reopen the log file when the rollover was unsuccessfulSee also #3021 (comment)
Checklist
2.xbranch if you are targeting Log4j 2; usemainotherwise./mvnw verifysucceeds (if it fails due to code formatting issues reported by Spotless, simply run./mvnw spotless:applyand retry)src/changelog/.2.x.xdirectory