Create DefaultLayout independent of PatternLayout
#3118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `PatternLayout` and all its patterns are a required element of Log4j Core, since `DefaultConfiguration` uses it. The default configuration is used in all Log4j Core installation as failsafe to handle logging between the time a logger context is created and the real configuration starts (a couple of ms). This PR creates a simple hardcoded layout to use with `DefaultConfiguration`.
vy
reviewed
Oct 24, 2024
log4j-core/src/main/java/org/apache/logging/log4j/core/config/DefaultConfiguration.java
Outdated
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/config/DefaultConfiguration.java
Outdated
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/config/DefaultConfiguration.java
Outdated
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/config/DefaultConfiguration.java
Outdated
Show resolved
Hide resolved
vy
approved these changes
Oct 25, 2024
log4j-core/src/main/java/org/apache/logging/log4j/core/config/DefaultLayout.java
Show resolved
Hide resolved
Co-authored-by: Volkan Yazıcı <volkan@yazi.ci>
23 tasks
ppkarwasz
added a commit
that referenced
this pull request
Apr 1, 2025
Currently, `PatternLayout` and all its patterns are a required element of Log4j Core, since `DefaultConfiguration` uses it. The default configuration is used in all Log4j Core installation as failsafe to handle logging between the time a logger context is created and the real configuration starts (a couple of ms). This PR creates a simple hardcoded layout to use with `DefaultConfiguration`, based on the `StatusData` formatter. (cherry picked from commit e8d5ffc) Co-authored-by: Piotr P. Karwasz <piotr.github@karwasz.org> Co-authored-by: Volkan Yazıcı <volkan@yazi.ci>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
PatternLayoutand all its patterns are a required element of Log4j Core, sinceDefaultConfigurationuses it. The default configuration is used in all Log4j Core installation as failsafe to handle logging between the time a logger context is created and the real configuration starts (a couple of ms).This PR creates a simple hardcoded layout to use with
DefaultConfiguration.