Fix StatusLogger time-zone issues and stack overflow
#2322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without a time-zone, it is not possible to format certain date & time fields that are time-zone-specific, e.g., year-of-era.
vy
added
bug
ppkarwasz
approved these changes
Feb 23, 2024
log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java
Outdated
Show resolved
Hide resolved
log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java
Outdated
Show resolved
Hide resolved
rgoers
approved these changes
Feb 25, 2024
Member
rgoers
left a comment
rgoers
left a comment
There was a problem hiding this comment.
The property name change is pretty minor. Everything else looks good.
log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java
Show resolved
Hide resolved
ppkarwasz
approved these changes
Feb 27, 2024
...test/src/test/java/org/apache/logging/log4j/status/StatusLoggerPropertiesUtilDoubleTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves
StatusLoggersuch thatlog4j2.StatusLogger.DateFormatZoneconfiguration property is introduced. This sets the time-zoneStatusLoggeruses to formatjava.time.Instant. Without this formatting patterns accessing to time-zone-specific fields (e.g., year-of-era) cause failures. The value defaults toZoneId.systemDefault().StatusLoggeris improved to avoid stack overflow caused byStatusLogger#logMessage()failures.These issues are originally reported by @lauredogit here: #2249 (comment)