Upgrade 2.x compiler baseline to Java 17
#2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JEP-335 has deprecated Nashorn in Java 11, and JEP-372 removed it in Java 15.
This is necessary for Java 12+ compatibility.
ppkarwasz
requested changes
Nov 30, 2023
...e-test/src/test/java/org/apache/logging/log4j/core/pattern/DatePatternConverterTestBase.java
Outdated
Show resolved
Hide resolved
Member
Author
Thanks so much for the review, much appreciated! 🙏 I have reverted test dependency upgrades. I will merge the changes sometime today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning!
revisionneeds to be adjusted prior to merge.