Skip to content

Port log4j-to-slf4j changes from 2.x #2015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2023
Merged

Port log4j-to-slf4j changes from 2.x #2015

merged 1 commit into from
Nov 29, 2023

Conversation

vy
Copy link
Member

@vy vy commented Nov 28, 2023

No description provided.

@vy vy added this to the 3.0.0 milestone Nov 28, 2023
@vy vy self-assigned this Nov 28, 2023
@vy vy force-pushed the main-sync-log4j-to-slf4j branch from 37157b7 to 3e728a2 Compare November 28, 2023 20:46
@vy vy requested a review from ppkarwasz November 28, 2023 20:46
@vy vy mentioned this pull request Nov 28, 2023
Closed
ppkarwasz
ppkarwasz requested changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but we might require an SLF4J/Logback upgrade:

  • bump SLF4J to 2.0.9 (like 2.x),
  • bump Logback to 1.4.11 (2.x uses the 1.3.x branch, since the 1.4.x branch requires Java 11).

@vy
Copy link
Member Author

vy commented Nov 29, 2023

This looks good to me but we might require an SLF4J/Logback upgrade:

  • bump SLF4J to 2.0.9 (like 2.x),
  • bump Logback to 1.4.11 (2.x uses the 1.3.x branch, since the 1.4.x branch requires Java 11).

I will address this while sync'ing log4j-parent. I would like to proceed one module at a time.

@ppkarwasz
Copy link
Contributor

ppkarwasz commented Nov 29, 2023 •
edited
Loading

This looks good to me but we might require an SLF4J/Logback upgrade:

  • bump SLF4J to 2.0.9 (like 2.x),
  • bump Logback to 1.4.11 (2.x uses the 1.3.x branch, since the 1.4.x branch requires Java 11).

I will address this while sync'ing log4j-parent. I would like to proceed one module at a time.

I cherry picked the "Bump SLF4J to version 2.0.9" commit from 2.x. It should be OK now.

Logback was bumped to 1.3.11 only, because 1.4.11 has a broken OSGi descriptor.

@vy vy force-pushed the main-sync-log4j-to-slf4j branch from 3e728a2 to e3e0a35 Compare November 29, 2023 12:13
@vy vy merged commit 6564ffb into main Nov 29, 2023
@vy vy deleted the main-sync-log4j-to-slf4j branch November 29, 2023 12:15
@ppkarwasz ppkarwasz modified the milestones: 3.0.0, 3.0.0-beta1 Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppkarwasz ppkarwasz ppkarwasz requested changes

Assignees

@vy vy

Labels
None yet
Projects
None yet
Milestone
3.0.0-beta1
Development

Successfully merging this pull request may close these issues.
2 participants
@vy @ppkarwasz