Allow multiple Log4jServletContextListener registrations #1784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppkarwasz
force-pushed
the
context-listener
branch
from
d620881 to
1b79941
Compare
|
This PR was tested on a simple Servlet API project. |
ppkarwasz
force-pushed
the
context-listener
branch
from
1b79941 to
3e334dd
Compare
ppkarwasz
force-pushed
the
context-listener
branch
from
3e334dd to
6e500bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the user to declare a
Log4jServletContextListenerexplicitly in aweb.xmldescriptor (additionally to the one installed byLog4jServletContainerListener).Due to the way the Servlet API works, the only way for
Log4jServletContextListenerto shutdown the context after all other listeners is to declare it explicitly in aweb.xmldescriptor.Closes #1782.