Removed unused FastDateParser (LOG4J2-3672, #1848)

Author: vy

log4j-core-test/src/test/java/org/apache/logging/log4j/core/util/datetime/FastDateParserTest.java

@@ -296,6 +296,21 @@
         </executions>
       </plugin>
 
+      <!-- Remove this override after `2.22.0` release!
+           In `2.22.0`, we have removed *unused* `FastDateParser` due to LOG4J2-3672 and #1848.
+           Though `bnd-baseline-m-p` doesn't allow such breaking changes in non-major version upgrades.
+           Hence, we suppress it until `2.22.0` gets released. -->
+      <plugin>
+        <groupId>biz.aQute.bnd</groupId>
+        <artifactId>bnd-baseline-maven-plugin</artifactId>
+        <configuration>
+          <diffpackages>
+            <diffpackage>!org.apache.logging.log4j.core.util.datetime</diffpackage>
+            <diffpackage>*</diffpackage>
+          </diffpackages>
+        </configuration>
+      </plugin>
+
     </plugins>
   </build>
 </project>

log4j-core/pom.xml

@@ -18,8 +18,6 @@
 
 import java.text.DateFormat;
 import java.text.FieldPosition;
-import java.text.ParseException;
-import java.text.ParsePosition;
 import java.util.Calendar;
 import java.util.Date;
 import java.util.Locale;
@@ -72,15 +70,7 @@
  *
  * @since Apache Commons Lang 2.0
  */
-public class FastDateFormat extends Format implements DateParser, DatePrinter {
-
-    /**
-     * Required for serialization support.
-     *
-     * @see java.io.Serializable
-     */
-    @SuppressWarnings("unused")
-    private static final long serialVersionUID = 2L;
+public class FastDateFormat extends Format implements DatePrinter {
 
     /**
      * FULL locale dependent date or time style.
@@ -110,7 +100,6 @@ protected FastDateFormat createInstance(final String pattern, final TimeZone tim
     };
 
     private final FastDatePrinter printer;
-    private final FastDateParser parser;
 
     //-----------------------------------------------------------------------
     /**
@@ -399,7 +388,6 @@ protected FastDateFormat(final String pattern, final TimeZone timeZone, final Lo
      */
     protected FastDateFormat(final String pattern, final TimeZone timeZone, final Locale locale, final Date centuryStart) {
         printer= new FastDatePrinter(pattern, timeZone, locale);
-        parser= new FastDateParser(pattern, timeZone, locale, centuryStart);
     }
 
     // Format methods
@@ -495,43 +483,6 @@ public <B extends Appendable> B format(final Calendar calendar, final B buf) {
         return printer.format(calendar, buf);
     }
 
-    // Parsing
-    //-----------------------------------------------------------------------
-
-
-    /* (non-Javadoc)
-     * @see DateParser#parse(java.lang.String)
-     */
-    @Override
-    public Date parse(final String source) throws ParseException {
-        return parser.parse(source);
-    }
-
-    /* (non-Javadoc)
-     * @see DateParser#parse(java.lang.String, java.text.ParsePosition)
-     */
-    @Override
-    public Date parse(final String source, final ParsePosition pos) {
-        return parser.parse(source, pos);
-    }
-
-    /*
-     * (non-Javadoc)
-     * @see org.apache.commons.lang3.time.DateParser#parse(java.lang.String, java.text.ParsePosition, java.util.Calendar)
-     */
-    @Override
-    public boolean parse(final String source, final ParsePosition pos, final Calendar calendar) {
-        return parser.parse(source, pos, calendar);
-    }
-
-    /* (non-Javadoc)
-     * @see java.text.Format#parseObject(java.lang.String, java.text.ParsePosition)
-     */
-    @Override
-    public Object parseObject(final String source, final ParsePosition pos) {
-        return parser.parseObject(source, pos);
-    }
-
     // Accessors
     //-----------------------------------------------------------------------
     /**
@@ -589,7 +540,7 @@ public int getMaxLengthEstimate() {
      */
     @Override
     public boolean equals(final Object obj) {
-        if (obj instanceof FastDateFormat == false) {
+        if (!(obj instanceof FastDateFormat)) {
             return false;
         }
         final FastDateFormat other = (FastDateFormat) obj;