remove String.format

Author: alan0428a

log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/ClassResourceInfo.java

@@ -18,7 +18,7 @@
 
 import java.net.URL;
 import java.security.CodeSource;
-import org.apache.logging.log4j.util.Lazy;
+import java.util.function.Consumer;
 
 /**
  * Resource information (i.e., the enclosing JAR file and its version) of a class.
@@ -27,32 +27,35 @@ final class ClassResourceInfo {
 
     static final ClassResourceInfo UNKNOWN = new ClassResourceInfo();
 
-    private final Lazy<String> textRef;
+    private final Consumer<StringBuilder> consumer;
 
     final Class<?> clazz;
 
     /**
      * Constructs an instance modelling an unknown class resource.
      */
     private ClassResourceInfo() {
-        this.textRef = Lazy.value("~[?:?]");
-        this.clazz = null;
+        this.consumer = (buffer) -> buffer.append("~[?:?]");
+        clazz = null;
     }
 
     /**
      * @param clazz the class
      * @param exact {@code true}, if the class was obtained via reflection; {@code false}, otherwise
      */
     ClassResourceInfo(final Class<?> clazz, final boolean exact) {
-        this.clazz = clazz;
-        this.textRef = Lazy.lazy(() -> getText(clazz, exact));
-    }
-
-    private static String getText(final Class<?> clazz, final boolean exact) {
         final String exactnessPrefix = exact ? "" : "~";
         final String location = getLocation(clazz);
         final String version = getVersion(clazz);
-        return String.format("%s[%s:%s]", exactnessPrefix, location, version);
+        this.consumer = (buffer) -> {
+            buffer.append(exactnessPrefix);
+            buffer.append("[");
+            buffer.append(location);
+            buffer.append(":");
+            buffer.append(version);
+            buffer.append("]");
+        };
+        this.clazz = clazz;
     }
 
     private static String getLocation(final Class<?> clazz) {
@@ -86,8 +89,7 @@ private static String getVersion(final Class<?> clazz) {
         return "?";
     }
 
-    @Override
-    public String toString() {
-        return textRef.get();
+    public void render(final StringBuilder buffer) {
+        this.consumer.accept(buffer);
     }
 }

log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/ThrowableExtendedStackTraceRenderer.java

@@ -75,7 +75,7 @@ void renderStackTraceElement(
                 context.classResourceInfoByName.get(stackTraceElement.getClassName());
         if (classResourceInfo != null) {
             buffer.append(' ');
-            buffer.append(classResourceInfo);
+            classResourceInfo.render(buffer);
         }
         buffer.append(lineSeparator);
     }