Improve line splitting on Windows

ppkarwasz · ppkarwasz · commit 2dad314433dc · 2024-09-09T10:20:52.000+02:00
diff --git a/log4j-parent/pom.xml b/log4j-parent/pom.xml
@@ -1045,7 +1045,7 @@
                       throw new RuntimeException('Failed to decompile the module descriptor in ' + jarFile + ':\n' + err)
                   }
                   log.debug('Module descriptor: ' + out)
-                  for (String line : out.toString().split(System.lineSeparator(), -1)) {
+                  for (String line : out.toString().split('\r?\n', -1)) {
                       if (line.contains('static') && line.contains('transitive')) {
                           throw new RuntimeException("The 'static' and 'transitive' modifiers should not be use together: " + line)
                       }

Original file line number	Diff line number	Diff line change
`@@ -1045,7 +1045,7 @@`
`1045`	`1045`	`throw new RuntimeException('Failed to decompile the module descriptor in ' + jarFile + ':\n' + err)`
`1046`	`1046`	`}`
`1047`	`1047`	`log.debug('Module descriptor: ' + out)`
`1048`		`- for (String line : out.toString().split(System.lineSeparator(), -1)) {`
	`1048`	`+ for (String line : out.toString().split('\r?\n', -1)) {`
`1049`	`1049`	`if (line.contains('static') && line.contains('transitive')) {`
`1050`	`1050`	`throw new RuntimeException("The 'static' and 'transitive' modifiers should not be use together: " + line)`
`1051`	`1051`	`}`