Skip to content

Conversation

@pjfanning
Copy link
Member

@pjfanning pjfanning commented Sep 29, 2023

based on comments in #26

fyi @vy

@vy
Copy link
Member

vy commented Sep 29, 2023

@pjfanning, thanks so much! 🙇

@vy
Copy link
Member

vy commented Sep 29, 2023

@pjfanning, you need to sign your commits. Could you do that, please? Otherwise, I cannot (am not allowed to) merge it.

@pjfanning
Copy link
Member Author

pjfanning commented Sep 29, 2023

I have opened an issue with GitHub - it could take a while. They are marking my signed commits as unverified and it's not clear why. I will close this. Feel free to reuse my code yourself. I place this code in the public domain.

It could be down to the fact that my git commits use my noreply GitHub email address instead of my real email address but I don't want to expose the real email address.

@pjfanning pjfanning closed this Sep 29, 2023
@vy
Copy link
Member

vy commented Oct 2, 2023

Thanks @pjfanning! Cherry-picked your stuff in 468ab8c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants