[KYUUBI #6437] Fix Spark engine query result save to HDFS #6444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wForget some issues with local testing, and since the changes were minimal, I just submitted the PR. Please review. I'm build a dist to test in our internal cluster, will send result later. |
pan3793
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6444 +/- ##
============================================
+ Coverage 58.26% 58.30% +0.03%
Complexity 24 24
============================================
Files 656 656
Lines 40268 40264 -4
Branches 5498 5498
============================================
+ Hits 23463 23476 +13
+ Misses 14287 14283 -4
+ Partials 2518 2505 -13 ☔ View full report in Codecov by Sentry. |
cxzl25
approved these changes
Jun 3, 2024
|
tested with 1.9.1 + this PR, problem solved. ready to merge |
|
better performance and memory usage than
|
pan3793
pushed a commit
that referenced
this pull request
Jun 4, 2024
This pull request fixes #6437 Use `org.apache.hadoop.fs.Path` instead of `java.nio.file.Paths` to avoid `OPERATION_RESULT_SAVE_TO_FILE_DIR` scheme unexpected change. - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) Spark Job failed to start with error: `java.io.IOException: JuiceFS initialized failed for jfs:///` with conf `kyuubi.operation.result.saveToFile.dir=jfs://datalake/tmp`. `hdfs://xxx:port/tmp` may encounter similar errors User Can use hdfs dir as `kyuubi.operation.result.saveToFile.dir` without error. Seems no test suites added in #5591 and #5986, I'll try to build a dist and test with our internal cluster. --- - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6444 from camper42/save-to-hdfs. Closes #6437 990f0a7 [camper42] [Kyuubi #6437] Fix Spark engine query result save to HDFS Authored-by: camper42 <camper.xlii@gmail.com> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit 71649da) Signed-off-by: Cheng Pan <chengpan@apache.org>
|
Thanks, merged to master/1.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This pull request fixes #6437
Describe Your Solution 🔧
Use
org.apache.hadoop.fs.Pathinstead ofjava.nio.file.Pathsto avoidOPERATION_RESULT_SAVE_TO_FILE_DIRscheme unexpected change.Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Spark Job failed to start with error:
java.io.IOException: JuiceFS initialized failed for jfs:///with confkyuubi.operation.result.saveToFile.dir=jfs://datalake/tmp.hdfs://xxx:port/tmpmay encounter similar errorsBehavior With This Pull Request 🎉
User Can use hdfs dir as
kyuubi.operation.result.saveToFile.dirwithout error.Related Unit Tests
Seems no test suites added in #5591 and #5986, I'll try to build a dist and test with our internal cluster.
Checklist 📝
Be nice. Be informative.