Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #6052] Support to delete EngineSpace ZNodes in all share levels #6086

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

zhouyifan279
Copy link
Contributor

@zhouyifan279 zhouyifan279 commented Feb 26, 2024

🔍 Description

Issue References 🔗

This pull request implements #6052

Describe Your Solution 🔧

This PR introduced a new config kyuubi.ha.engine.cleanup.enabled.

If kyuubi.ha.engine.cleanup.enabled is set to true, Engine will delete namespace node and lock node on ZooKeeper when stops.
This feature can be used to cleanup ZooKeeper nodes created by Engine with random subdomains.

Note: User should guarantee Engine with same namespace won't be launched before old Engine stops. Otherwise, errors may happen when launching new Engine.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Engine namespace node and lock node remain when Engine stops.

Behavior With This Pull Request 🎉

If kyuubi.ha.engine.cleanup.enabled is set to true, Engine will delete namespace node and lock node when stops.

Related Unit Tests

Kyuubi #6052: Cleanup engine namespace node and lock node


Checklist 📝

Be nice. Be informative.

@zhouyifan279
Copy link
Contributor Author

cc @yaooqinn @pan3793

@github-actions github-actions bot added the kind:documentation Documentation is a feature! label Feb 26, 2024
@pan3793 pan3793 changed the title [Kyuubi #6052] Support to delete EngineSpace ZNodes in all share levels [KYUUBI #6052] Support to delete EngineSpace ZNodes in all share levels Feb 26, 2024
@pan3793
Copy link
Member

pan3793 commented Mar 7, 2024

Looks a little bit dangerous, WDYT @yaooqinn?

@pan3793
Copy link
Member

pan3793 commented Mar 7, 2024

Forward ideas from offline discussion, an alternative approach is providing CLI tool to allow administrators to manually clean the subdomain nodes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants