[KYUUBI #3325] [FEATURE] [AUTHZ] Privilege checks for permanent views and skipping shadowed tables #3326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenliang123
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3326 +/- ##
============================================
- Coverage 51.49% 51.45% -0.04%
Complexity 13 13
============================================
Files 475 479 +4
Lines 26491 26556 +65
Branches 3698 3707 +9
============================================
+ Hits 13641 13664 +23
- Misses 11522 11560 +38
- Partials 1328 1332 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yaooqinn
reviewed
Aug 25, 2022
...rk-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/ranger/ViewAccessAnalysis.scala
Outdated
Show resolved
Hide resolved
yaooqinn
reviewed
Aug 25, 2022
...rk-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/ranger/ViewAccessAnalysis.scala
Outdated
Show resolved
Hide resolved
yaooqinn
reviewed
Aug 25, 2022
...kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/util/AuthZUtils.scala
Outdated
Show resolved
Hide resolved
yaooqinn
reviewed
Aug 25, 2022
...kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/util/AuthZUtils.scala
Outdated
Show resolved
Hide resolved
yaooqinn
reviewed
Aug 25, 2022
...rk-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/ranger/ViewAccessAnalysis.scala
Outdated
Show resolved
Hide resolved
yaooqinn
reviewed
Aug 25, 2022
...rk-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/ranger/ViewAccessAnalysis.scala
Outdated
Show resolved
Hide resolved
yaooqinn
reviewed
Aug 25, 2022
...z/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RangerSparkExtensionSuite.scala
Outdated
Show resolved
Hide resolved
yaooqinn
reviewed
Aug 25, 2022
...z/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RangerSparkExtensionSuite.scala
Outdated
Show resolved
Hide resolved
bowenliang123
changed the title
bowenliang123
changed the title
bowenliang123
changed the title
yaooqinn
reviewed
Aug 25, 2022
| @@ -129,6 +130,9 @@ object PrivilegesBuilder { | |||
| val db = quote(parts.init) | |||
| privilegeObjects += tablePrivileges(TableIdentifier(parts.last, Some(db))) | |||
|
|
|||
| case permanentViewMarker: PermanentViewMarker => | |||
There was a problem hiding this comment.
case PermanentViewMarker(child, table) => mergeProjection(table, child)
looks we need to change to the above one, we may still project a view
There was a problem hiding this comment.
OK.
Changed to mergeProjection, and checking column level privileges for perm views.
yaooqinn
reviewed
Aug 25, 2022
...rc/main/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RuleApplyPermanentViewMarker.scala
Outdated
Show resolved
Hide resolved
yaooqinn
approved these changes
Aug 25, 2022
…PrivilegesBuilder with PermanentViewMarker, finally maker cleanup in RuleEliminateViewMarker
… non-existed isTempView field
Squashed commits: [98f523d] fix error in view casting
bowenliang123
force-pushed
the
feature-authz-perm-view
branch
from
2342d6a
to
81e8b99
Compare
|
hi @bowenliang123, please help resolve the conflicts when you have time |
|
@yaooqinn sure. will do it soon. |
# Conflicts: # extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RangerSparkExtensionSuite.scala
yaooqinn
approved these changes
Aug 29, 2022
|
some ut for selecting unauthed view added and it remains unexpected error. |
3 tasks
yaooqinn
approved these changes
Aug 30, 2022
|
thanks, merged to master |
4 tasks
4 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
fix #3325
Permanent views are generally registed globally and then used for unifing, masking, joining tables for different practical purposes. The data manager would like to authorize views to users , but not all the source tables.
Authz plugin is not satisfiying this senario as it checks privileges all the source table instead of the permanent views.
Suggesting chaning behaviour of PrivilegesBuilder
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request