Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK][EASY] DeRegisterWatcher should re-watch when any event is received #6477

Closed
3 tasks done
cxzl25 opened this issue Jun 18, 2024 · 2 comments
Closed
3 tasks done
Assignees

Comments

@cxzl25
Copy link
Contributor

cxzl25 commented Jun 18, 2024

What's the level of this task?

EASY

Code of Conduct

Search before creating

  • I have searched in the task list and found no similar tasks.

Mentor

  • I have sufficient expertise on this task, and I volunteer to be a mentor of this task to guide contributors through the task.

Skill requirements

  • Basic knowledge on Scala programming language

Background and Goals

The NodeDataChanged event listener is implemented at #3543, but there is still a small chance that the watch event will be lost.

In the internal version of the fix, we receive any event that implements rewatch.

The following log shows that it received Watcher.Event.EventType#None.

24/06/17 07:33:14,909 [main-EventThread] WARN ZookeeperDiscoveryClient: This Kyuubi instance xxx (znode null) receives None
24/06/17 07:33:17,201 [main-EventThread] INFO ConnectionStateManager: State change: SUSPENDED
24/06/17 07:33:17,202 [main-EventThread] WARN ZookeeperDiscoveryClient: This Kyuubi instance xxx:xx (znode null) receives None

Implementation steps

DeRegisterWatcher should re-watch when any event is received

Additional context

Introduction of 2024H1 Kyuubi Code Contribution Program

@CavemanIV
Copy link
Contributor

Let me take care of this issue please

@cxzl25 cxzl25 closed this as completed Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants