Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK][EASY] Support get SQL keywords from Spark engine through API #5860

Open
2 of 4 tasks
pan3793 opened this issue Dec 15, 2023 · 4 comments
Open
2 of 4 tasks

[TASK][EASY] Support get SQL keywords from Spark engine through API #5860

pan3793 opened this issue Dec 15, 2023 · 4 comments
Labels

Comments

@pan3793
Copy link
Member

pan3793 commented Dec 15, 2023

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the feature

SPARK-43119(Spark 3.5.0) added a SQLKeywordUtils.keywords to preserve all SQL keywords, and return such value through GetInfo#CLI_ODBC_KEYWORDS, we can do similar things at the Kyuubi side.

Motivation

No response

Describe the solution

No response

Additional context

No response

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
  • No. I cannot submit a PR at this time.
@pan3793
Copy link
Member Author

pan3793 commented Dec 15, 2023

This ticket is for Spark, can we achieve a similar functionality in other engines? cc @YesOrNo828 @iodone @yikf

@iodone
Copy link
Contributor

iodone commented Dec 25, 2023

The Trino engine currently does not support an API for keyword retrieval.

@yikf
Copy link
Contributor

yikf commented Dec 25, 2023

Hi @iodone , I found a newer commit that provided the API, but I didn't track its previous status, FYI: https://github.com/trinodb/trino/blob/master/core/trino-grammar/src/main/java/io/trino/grammar/sql/SqlKeywords.java#L31

@iodone
Copy link
Contributor

iodone commented Dec 25, 2023

It appears that the trino-cli has used this API, rather than the sql keyword information provided by the trino server.

Hi @iodone , I found a newer commit that provided the API, but I didn't track its previous status, FYI: https://github.com/trinodb/trino/blob/master/core/trino-grammar/src/main/java/io/trino/grammar/sql/SqlKeywords.java#L31

@pan3793 pan3793 changed the title [FEATURE] Support get SQL keywords from Spark engine through API [TASK][EASY] Support get SQL keywords from Spark engine through API Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants