Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK][EASY] Support chain SessionConfAdvisor #5423

Closed
3 of 4 tasks
cxzl25 opened this issue Oct 16, 2023 · 1 comment
Closed
3 of 4 tasks

[TASK][EASY] Support chain SessionConfAdvisor #5423

cxzl25 opened this issue Oct 16, 2023 · 1 comment
Assignees
@lsm1
Labels
hacktoberfest kind:feature Feature request priority:major

Comments

@cxzl25
Copy link
Contributor

cxzl25 commented Oct 16, 2023

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the feature

Now we have a built-in FileSessionConfAdvisor, but users may have other SessionConfAdvisors, and multiple Advisors cannot work together.

kyuubi.session.conf.advisor only supports configuring one.

If we support chained SessionConfAdvisor, we can support multiple SessionConfAdvisor.

Motivation

No response

Describe the solution

No response

Additional context

No response

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
  • No. I cannot submit a PR at this time.
@cxzl25 cxzl25 changed the title [FEATURE] Support chain SessionConfAdvisor [TASK][EASY] Support chain SessionConfAdvisor Oct 17, 2023
@lsm1
Copy link
Contributor

lsm1 commented Oct 18, 2023 •
edited
Loading

I will try it, please assign to me

@lsm1 lsm1 mentioned this issue Oct 19, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lsm1 lsm1

Labels
hacktoberfest kind:feature Feature request priority:major
Projects
No open projects
2023 Kyuubi Code Contribution Program
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[KYUUBI #5423] Support chaining SessionConfAdvisors lsm1/kyuubi
3 participants
@cxzl25 @lsm1 @pan3793