Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK][EASY] Pretty print exception for Kyuubi Event #5397

Closed
3 tasks done
wForget opened this issue Oct 11, 2023 · 3 comments
Closed
3 tasks done

[TASK][EASY] Pretty print exception for Kyuubi Event #5397

wForget opened this issue Oct 11, 2023 · 3 comments

Comments

@wForget
Copy link
Member

wForget commented Oct 11, 2023

Code of Conduct

Search before creating

  • I have searched in the task list and found no similar tasks.

Mentor

  • I have sufficient knowledge and experience of this task, and I volunteer to be the mentor of this task to guide contributors to complete the task.

Skill requirements

  • Knowledge of Kyuubi
  • Familiar with the open-source ecosystem

Background and Goals

As discussed in #5390, KyuubiEvent in json format is less readable due to the exception attribute of the event. We can pretty print exception attribute during json serialization.

Implementation steps

  • Add a custom ThrowableSerializer for org.apache.kyuubi.events.JsonProtocol#mapper.
  • Make this behavior configurable

Additional context

No response

@wForget wForget assigned wForget and unassigned wForget Oct 11, 2023
@fastPassion
Copy link

hello,I am interested in contributing to this project,please give me a chance to complete this task。

@pan3793
Copy link
Member

pan3793 commented Oct 11, 2023

@fastPassion thanks, assigned

@wForget
Copy link
Member Author

wForget commented Oct 11, 2023

BTW, the org.apache.kyuubi.Utils#prettyPrint method is already provided in kyuubi-common and you may need it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants