Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK][EASY] JDBC Engine supports PostgreSQL #5375

Closed
2 of 3 tasks
pan3793 opened this issue Oct 8, 2023 · 8 comments
Closed
2 of 3 tasks

[TASK][EASY] JDBC Engine supports PostgreSQL #5375

pan3793 opened this issue Oct 8, 2023 · 8 comments
Assignees

Comments

@pan3793
Copy link
Member

pan3793 commented Oct 8, 2023

Code of Conduct

Search before creating

  • I have searched in the task list and found no similar tasks.

Mentor

  • I have sufficient knowledge and experience of this task, and I volunteer to be the mentor of this task to guide contributors to complete the task.

Skill requirements

  • Basic knowledge of Scala programming language
  • Basic knowledge of JDBC concepts
  • Basic knowledge of Docker and Testcontianers

Background and Goals

Currently, Kyuubi supports JDBC engines with limited dialects, e.g. Doris, Phoenix, we can easily extend the dialects to support more databases.

Reference https://www.bilibili.com/video/BV1UT411m7LR

Implementation steps

  • Implement a PostgreSQL dialect in the JDBC engine
  • Leverage the Testcontainers to add integration tests
  • Update document correspondingly

Additional context

No response

@ymZhao1001
Copy link
Contributor

hello,can i take this?

@ymZhao1001
Copy link
Contributor

Implementation steps

  • Implement a ClickHouse dialect in the JDBC engine
  • Leverage the Testcontainers to add integration tests
  • Update document correspondingly

ClickHouse or PostgreSQL?

@pan3793
Copy link
Member Author

pan3793 commented Oct 9, 2023

Yea, of course, it's part of 2023 Kyuubi Code Contribution Program

How to take a task?

Please comment under the certain issue with a reasonable estimated deadline(e.g. about 3 days) if you would like to take the task. To enable as many tasks as possible to be solved, the mentors/committers may REVOKE the assignment if the contributor has no response/progress in time.

@pan3793
Copy link
Member Author

pan3793 commented Oct 9, 2023

ClickHouse or PostgreSQL?

Corrected the description, this is for PG, other popular RDBMS is welcome too

@pan3793
Copy link
Member Author

pan3793 commented Oct 10, 2023

@ymZhao1001 please provide a "reasonable estimated deadline" as mentioned above

@phionex0571
Copy link

phionex0571 commented Oct 10, 2023

@pan3793 Hello, I have used Apache kyuubi since version 1.6.1 and I have strong interests on it, can i implement this? I think it's resonable to finish this feature in 7 days. If it's OK, please asign this to me, thx~

@pan3793
Copy link
Member Author

pan3793 commented Oct 10, 2023

@phionex0571 thanks for your passion, this task was assigned to another contributor, but you can choose to implement another JDBC dialect, e.g. Oracle, DB2, feel free to send PR directly, your contribution will be counted eventually.

@ymZhao1001
Copy link
Contributor

@ymZhao1001 please provide a "reasonable estimated deadline" as mentioned above

ok. i will try to finish this in a week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants