Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FlakyTest] ServiceControlCliArgumentsSuite #2430

Open
2 of 3 tasks
Tracked by #1733
cfmcgrady opened this issue Apr 21, 2022 · 3 comments
Open
2 of 3 tasks
Tracked by #1733

[FlakyTest] ServiceControlCliArgumentsSuite #2430

cfmcgrady opened this issue Apr 21, 2022 · 3 comments
Labels
kind:subtask a subtask of umbrella ticket

Comments

@cfmcgrady
Copy link
Contributor

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the subtask

https://lists.apache.org/thread/g0ydjyo9893f0dvvmgg3sgkkfcr2xzm6

Run starting. Expected test count is: 24
ServiceControlCliArgumentsSuite:
- test basic kyuubi service arguments parser *** FAILED ***
  "[zhangduo-ubuntu]" did not equal "[localhost]"
(ServiceControlCliArgumentsSuite.scala:99)
  Analysis:
  "[zhangduo-ubuntu]" -> "[localhost]"
- prints usage on empty input
- prints error with unrecognized options
- test invalid arguments
- test extra unused arguments
- test list action arguments
- test get/delete action arguments
- test with unknown host
- test with invalid port specification
- test create action arguments
- test use default property value if missing
- test use short options *** FAILED ***
  "[zhangduo-ubuntu]" did not equal "[localhost]"
(ServiceControlCliArgumentsSuite.scala:333)
  Analysis:
  "[zhangduo-ubuntu]" -> "[localhost]"
- test --help

Parent issue

#1733

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@cfmcgrady cfmcgrady added the kind:subtask a subtask of umbrella ticket label Apr 21, 2022
@Apache9
Copy link

Apache9 commented Apr 21, 2022

It seems related to how we get the machine name. My machine name is zhangduo-ubuntu, so in general, 'zhangduo-ubuntu' points to the same machine with 'localhost'.

@yaooqinn
Copy link
Member

Look like the expected result in the test is hardcoded with localhost, while the actual one is getting from canonicalized hostname.

@cxzl25
Copy link
Contributor

cxzl25 commented Apr 25, 2022

--host will now keep the original value in this PR(#2461), so this problem should not occur.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:subtask a subtask of umbrella ticket
Projects
None yet
Development

No branches or pull requests

4 participants