Skip to content

Commit

Permalink
[KYUUBI #5754] [MINOR] Fix engine id of the engine probe failures log…
Browse files Browse the repository at this point in the history
…ging messages

# 🔍 Description
## Issue References 🔗

As described.

## Describe Your Solution 🔧

Fix the engine id in engine probe failures messages.

![image](https://github.com/apache/kyuubi/assets/1935105/6de038e7-efab-4197-a425-a5298259174d)

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklists
## 📝 Author Self Checklist

- [x] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project
- [x] I have performed a self-review
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

## 📝 Committer Pre-Merge Checklist

- [ ] Pull request title is okay.
- [ ] No license issues.
- [ ] Milestone correctly set?
- [ ] Test coverage is ok
- [ ] Assignees are selected.
- [ ] Minimum number of approvals
- [ ] No changes are requested

**Be nice. Be informative.**

Closes #5754 from bowenliang123/engineid-some.

Closes #5754

8936784 [Bowen Liang] fix engine id of the engine probe failures logging messages

Authored-by: Bowen Liang <liangbowen@gf.com.cn>
Signed-off-by: Bowen Liang <liangbowen@gf.com.cn>
  • Loading branch information
bowenliang123 committed Nov 23, 2023
1 parent fdcb456 commit f7bbe5b
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,11 @@ class KyuubiSyncThriftClient private (
remoteEngineBroken = false
} catch {
case e: Throwable =>
warn(s"The engine[$engineId] alive probe fails", e)
val engineIdStr = engineId.getOrElse("")
warn(s"The engine[$engineIdStr] alive probe fails", e)
val now = System.currentTimeMillis()
if (now - engineLastAlive > engineAliveTimeout) {
error(s"Mark the engine[$engineId] not alive with no recent alive probe" +
error(s"Mark the engine[$engineIdStr] not alive with no recent alive probe" +
s" success: ${now - engineLastAlive} ms exceeds timeout $engineAliveTimeout ms")
remoteEngineBroken = true
}
Expand Down

0 comments on commit f7bbe5b

Please sign in to comment.