Skip to content

Commit a38eda0

Browse files
committed
use thread name for error message
1 parent 6bc13b7 commit a38eda0

File tree

10 files changed

+14
-25
lines changed

10 files changed

+14
-25
lines changed

externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLEngine.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,8 +173,7 @@ case class SparkSQLEngine(spark: SparkSession) extends Serverable("SparkSQLEngin
173173
checkTask,
174174
interval,
175175
interval,
176-
TimeUnit.MILLISECONDS,
177-
"spark-engine-lifetime-terminating-checker")
176+
TimeUnit.MILLISECONDS)
178177
}
179178
}
180179
}

externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/session/SparkSQLSessionManager.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,7 @@ class SparkSQLSessionManager private (name: String, spark: SparkSession)
8585
},
8686
userIsolatedIdleInterval,
8787
userIsolatedIdleInterval,
88-
TimeUnit.MILLISECONDS,
89-
"user-isolated-spark-session-cache-checker")
88+
TimeUnit.MILLISECONDS)
9089
}
9190
}
9291
}

kyuubi-common/src/main/scala/org/apache/kyuubi/session/SessionManager.scala

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -330,8 +330,7 @@ abstract class SessionManager(name: String) extends CompositeService(name) {
330330
checkTask,
331331
interval,
332332
interval,
333-
TimeUnit.MILLISECONDS,
334-
"session-timeout-checker")
333+
TimeUnit.MILLISECONDS)
335334
}
336335

337336
private[kyuubi] def startTerminatingChecker(stop: () => Unit): Unit = if (!isServer) {
@@ -354,8 +353,7 @@ abstract class SessionManager(name: String) extends CompositeService(name) {
354353
checkTask,
355354
interval,
356355
interval,
357-
TimeUnit.MILLISECONDS,
358-
"session-manager-terminating-checker")
356+
TimeUnit.MILLISECONDS)
359357
}
360358
}
361359
}

kyuubi-common/src/main/scala/org/apache/kyuubi/util/ThreadUtils.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,14 +119,14 @@ object ThreadUtils extends Logging {
119119
runnable: Runnable,
120120
initialDelay: Long,
121121
delay: Long,
122-
timeUnit: TimeUnit,
123-
errorMessageHint: String): Unit = {
122+
timeUnit: TimeUnit): Unit = {
124123
scheduler.scheduleWithFixedDelay(
125124
() =>
126125
try {
127126
runnable.run()
128127
} catch {
129-
case e: Exception => error(s"Error in $errorMessageHint", e)
128+
case t: Throwable =>
129+
error(s"Uncaught exception in thread ${Thread.currentThread().getName}", t)
130130
},
131131
initialDelay,
132132
delay,

kyuubi-server/src/main/scala/org/apache/kyuubi/client/KyuubiSyncThriftClient.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,7 @@ class KyuubiSyncThriftClient private (
131131
task,
132132
engineAliveProbeInterval,
133133
engineAliveProbeInterval,
134-
TimeUnit.MILLISECONDS,
135-
"engine-alive-probe-checker")
134+
TimeUnit.MILLISECONDS)
136135
}
137136

138137
/**

kyuubi-server/src/main/scala/org/apache/kyuubi/credentials/HadoopCredentialsManager.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -305,8 +305,7 @@ class HadoopCredentialsManager private (name: String) extends AbstractService(na
305305
checkTask,
306306
credentialsCheckInterval,
307307
credentialsCheckInterval,
308-
TimeUnit.MILLISECONDS,
309-
"hadoop-credentials-timeout-checker")
308+
TimeUnit.MILLISECONDS)
310309
}
311310
}
312311

kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiRestFrontendService.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,7 @@ class KyuubiRestFrontendService(override val serverable: Serverable)
148148
task,
149149
interval,
150150
interval,
151-
TimeUnit.MILLISECONDS,
152-
"batch-checker")
151+
TimeUnit.MILLISECONDS)
153152
}
154153

155154
@VisibleForTesting

kyuubi-server/src/main/scala/org/apache/kyuubi/server/PeriodicGCService.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ class PeriodicGCService(name: String) extends AbstractService(name) {
4646
() => System.gc(),
4747
interval,
4848
interval,
49-
TimeUnit.MILLISECONDS,
50-
"periodic-gc-trigger")
49+
TimeUnit.MILLISECONDS)
5150
}
5251
}

kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/MetadataManager.scala

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -215,8 +215,7 @@ class MetadataManager extends AbstractService("MetadataManager") {
215215
cleanerTask,
216216
interval,
217217
interval,
218-
TimeUnit.MILLISECONDS,
219-
"metadata-cleaner")
218+
TimeUnit.MILLISECONDS)
220219
}
221220

222221
def addMetadataRetryRequest(request: MetadataRequest): Unit = {
@@ -307,8 +306,7 @@ class MetadataManager extends AbstractService("MetadataManager") {
307306
triggerTask,
308307
requestsRetryInterval,
309308
requestsRetryInterval,
310-
TimeUnit.MILLISECONDS,
311-
"metadata-request-async-retry-trigger")
309+
TimeUnit.MILLISECONDS)
312310
}
313311
}
314312

kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionManager.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -415,8 +415,7 @@ class KyuubiSessionManager private (name: String) extends SessionManager(name) {
415415
checkTask,
416416
interval,
417417
interval,
418-
TimeUnit.MILLISECONDS,
419-
"engine-connection-alive-checker")
418+
TimeUnit.MILLISECONDS)
420419
}
421420

422421
private def initEngineStartupProcessSemaphore(conf: KyuubiConf): Unit = {

0 commit comments

Comments
 (0)