Skip to content

Commit 70ad7e7

Browse files
committed
comment
1 parent c721a75 commit 70ad7e7

File tree

3 files changed

+10
-14
lines changed

3 files changed

+10
-14
lines changed

docs/deployment/migration-guide.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@
2121

2222
* Since Kyuubi 1.9.0, `kyuubi.session.conf.advisor` can be set as a sequence, Kyuubi supported chaining SessionConfAdvisors.
2323

24+
## Upgrading from Kyuubi 1.8.0 to 1.8.1
25+
26+
* Since Kyuubi 1.8.1, for `DELETE /batches/${batchId}`, `hive.server2.proxy.user` is not needed in the request parameters.
27+
2428
## Upgrading from Kyuubi 1.7 to 1.8
2529

2630
* Since Kyuubi 1.8, SQLite is added and becomes the default database type of Kyuubi metastore, as Derby has been deprecated.
@@ -32,8 +36,6 @@
3236
relative to `$KYUUBI_HOME` instead of `$PWD`.
3337
* Since Kyuubi 1.8, PROMETHEUS is changed as the default metrics reporter. To restore previous behavior,
3438
set `kyuubi.metrics.reporters=JSON`.
35-
* Since Kyuubi 1.8.1, for `DELETE /batches/${batchId}`, `proxyUser` and `hive.server2.proxy.user`
36-
are not needed in the request parameters.
3739

3840
## Upgrading from Kyuubi 1.7.1 to 1.7.2
3941

kyuubi-ctl/src/test/scala/org/apache/kyuubi/ctl/BatchCliArgumentsSuite.scala

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -119,18 +119,6 @@ class BatchCliArgumentsSuite extends KyuubiFunSuite with TestPrematureExit {
119119
}
120120
}
121121

122-
ignore("delete batch with hs2ProxyUser") {
123-
val args = Array(
124-
"delete",
125-
"batch",
126-
"f7fd702c-e54e-11ec-8fea-0242ac120002",
127-
"--hs2ProxyUser",
128-
"b_user")
129-
val opArgs = new ControlCliArguments(args)
130-
assert(opArgs.cliConfig.batchOpts.batchId == "f7fd702c-e54e-11ec-8fea-0242ac120002")
131-
assert(opArgs.cliConfig.commonOpts.hs2ProxyUser == "b_user")
132-
}
133-
134122
test("test list batch option") {
135123
val args = Array(
136124
"list",

kyuubi-rest-client/src/main/java/org/apache/kyuubi/client/BatchRestApi.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,11 @@
2323
import org.apache.kyuubi.client.api.v1.dto.*;
2424
import org.apache.kyuubi.client.util.JsonUtils;
2525
import org.apache.kyuubi.client.util.VersionUtils;
26+
import org.slf4j.Logger;
27+
import org.slf4j.LoggerFactory;
2628

2729
public class BatchRestApi {
30+
static final Logger LOG = LoggerFactory.getLogger(BatchRestApi.class);
2831

2932
private KyuubiRestClient client;
3033

@@ -107,6 +110,9 @@ public OperationLog getBatchLocalLog(String batchId, int from, int size) {
107110
*/
108111
@Deprecated
109112
public CloseBatchResponse deleteBatch(String batchId, String hs2ProxyUser) {
113+
LOG.warn(
114+
"The method `deleteBatch(batchId, hs2ProxyUser)` is deprecated since 1.8.1, "
115+
+ "using `deleteBatch(batchId)` instead.");
110116
Map<String, Object> params = new HashMap<>();
111117
params.put("hive.server2.proxy.user", hs2ProxyUser);
112118

0 commit comments

Comments
 (0)