Skip to content

Commit 58621b5

Browse files
committed
fix comments
1 parent 1bf81e7 commit 58621b5

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

docs/configuration/settings.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ You can configure the Kyuubi properties in `$KYUUBI_HOME/conf/kyuubi-defaults.co
347347
| kyuubi.metadata.store.jdbc.database.type | SQLITE | The database type for server jdbc metadata store.<ul> <li>(Deprecated) DERBY: Apache Derby, JDBC driver `org.apache.derby.jdbc.AutoloadedDriver`.</li> <li>SQLITE: SQLite3, JDBC driver `org.sqlite.JDBC`.</li> <li>MYSQL: MySQL, JDBC driver `com.mysql.jdbc.Driver`.</li> <li>CUSTOM: User-defined database type, need to specify corresponding JDBC driver.</li> Note that: The JDBC datasource is powered by HiKariCP, for datasource properties, please specify them with the prefix: kyuubi.metadata.store.jdbc.datasource. For example, kyuubi.metadata.store.jdbc.datasource.connectionTimeout=10000. | string | 1.6.0 |
348348
| kyuubi.metadata.store.jdbc.driver | &lt;undefined&gt; | JDBC driver class name for server jdbc metadata store. | string | 1.6.0 |
349349
| kyuubi.metadata.store.jdbc.password || The password for server JDBC metadata store. | string | 1.6.0 |
350-
| kyuubi.metadata.store.jdbc.priority.enabled | false | Whether to enable picking up jobs from the metadata store in order of priority.If this feature is disabled, setting kyuubi.batch.priority will not take effect.However, it is recommended to enable this feature if you already have a metadata store that can support mixed order indexing(such as MySQL 8).See why recommend this in https://github.com/apache/kyuubi/pull/5329 | boolean | 1.8.0 |
350+
| kyuubi.metadata.store.jdbc.priority.enabled | false | Whether to enable the priority scheduling for batch impl v2. When false, ignore kyuubi.batch.priority and use the FIFO ordering strategy for batch job scheduling. Note: this feature may cause significant performance issues when using MySQL 5.7 as the metastore backend due to the lack of support for mixed order index. See more details at KYUUBI #5329. | boolean | 1.8.0 |
351351
| kyuubi.metadata.store.jdbc.url | jdbc:sqlite:kyuubi_state_store.db | The JDBC url for server JDBC metadata store. By default, it is a SQLite database url, and the state information is not shared across kyuubi instances. To enable high availability for multiple kyuubi instances, please specify a production JDBC url. | string | 1.6.0 |
352352
| kyuubi.metadata.store.jdbc.user || The username for server JDBC metadata store. | string | 1.6.0 |
353353

kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStoreConf.scala

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -96,11 +96,11 @@ object JDBCMetadataStoreConf {
9696

9797
val METADATA_STORE_JDBC_PRIORITY_ENABLED: ConfigEntry[Boolean] =
9898
buildConf("kyuubi.metadata.store.jdbc.priority.enabled")
99-
.doc("Whether to enable picking up jobs from the metadata store in order of priority." +
100-
"If this feature is disabled, setting kyuubi.batch.priority will not take effect." +
101-
"However, it is recommended to enable this feature if you already have a metadata store " +
102-
"that can support mixed order indexing(such as MySQL 8)." +
103-
"See why recommend this in https://github.com/apache/kyuubi/pull/5329")
99+
.doc("Whether to enable the priority scheduling for batch impl v2. " +
100+
"When false, ignore kyuubi.batch.priority and use the FIFO ordering strategy " +
101+
"for batch job scheduling. Note: this feature may cause significant performance issues " +
102+
"when using MySQL 5.7 as the metastore backend due to the lack of support " +
103+
"for mixed order index. See more details at KYUUBI #5329.")
104104
.version("1.8.0")
105105
.serverOnly
106106
.booleanConf

0 commit comments

Comments
 (0)