Skip to content

Commit 36710d0

Browse files
committed
refactor
1 parent cd2e36f commit 36710d0

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

kyuubi-common/src/test/scala/org/apache/kyuubi/operation/SparkDataTypeTests.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
package org.apache.kyuubi.operation
1919

2020
import java.sql.{Date, Timestamp}
21-
import java.util.{Calendar, TimeZone}
21+
import java.util.Calendar
2222

2323
import org.apache.kyuubi.util.SparkVersionUtil
2424

@@ -238,11 +238,11 @@ trait SparkDataTypeTests extends HiveJDBCTestHelper with SparkVersionUtil {
238238
assert(resultSet.next())
239239
assert(resultSet.getTimestamp(
240240
"col",
241-
Calendar.getInstance(TimeZone.getTimeZone("UTC"))) === Timestamp.valueOf(
241+
Calendar.getInstance()) === Timestamp.valueOf(
242242
"2018-11-17 13:33:33"))
243243
assert(resultSet.getTimestamp(
244244
1,
245-
Calendar.getInstance(TimeZone.getTimeZone("UTC"))) === Timestamp.valueOf(
245+
Calendar.getInstance()) === Timestamp.valueOf(
246246
"2018-11-17 13:33:33"))
247247
val metaData = resultSet.getMetaData
248248
assert(metaData.getColumnType(1) === java.sql.Types.TIMESTAMP)

kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiArrowBasedResultSet.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -459,8 +459,8 @@ private Timestamp parseTimestamp(Timestamp timestamp, Calendar cal) {
459459
cal = Calendar.getInstance();
460460
}
461461
long v = timestamp.getTime();
462-
v -= cal.getTimeZone().getOffset(v);
463-
timestamp = new Timestamp(v);
462+
cal.setTimeInMillis(v);
463+
timestamp = new Timestamp(cal.getTime().getTime());
464464
return timestamp;
465465
}
466466

@@ -508,8 +508,8 @@ private Time parseTime(Time date, Calendar cal) {
508508
cal = Calendar.getInstance();
509509
}
510510
long v = date.getTime();
511-
v -= cal.getTimeZone().getOffset(v);
512-
date = new Time(v);
511+
cal.setTimeInMillis(v);
512+
date = new Time(cal.getTime().getTime());
513513
return date;
514514
}
515515

kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiBaseResultSet.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -465,8 +465,8 @@ private Timestamp parseTimestamp(Timestamp timestamp, Calendar cal) {
465465
cal = Calendar.getInstance();
466466
}
467467
long v = timestamp.getTime();
468-
v -= cal.getTimeZone().getOffset(v);
469-
timestamp = new Timestamp(v);
468+
cal.setTimeInMillis(v);
469+
timestamp = new Timestamp(cal.getTime().getTime());
470470
return timestamp;
471471
}
472472

@@ -514,8 +514,8 @@ private Time parseTime(Time date, Calendar cal) {
514514
cal = Calendar.getInstance();
515515
}
516516
long v = date.getTime();
517-
v -= cal.getTimeZone().getOffset(v);
518-
date = new Time(v);
517+
cal.setTimeInMillis(v);
518+
date = new Time(cal.getTime().getTime());
519519
return date;
520520
}
521521

0 commit comments

Comments
 (0)