Skip to content

Commit 19ae399

Browse files
cxzl25pan3793
authored andcommitted
[KYUUBI #5785] Fix flaky test - JpsApplicationOperation with spark local mode
# 🔍 Description ## Issue References 🔗 This pull request fixes #2642 ## Describe Your Solution 🔧 #2669 (comment) ```bash jps -ml ``` ``` 99427 org.apache.spark.launcher.Main org.apache.spark.deploy.SparkSubmit --class org.apache.spark.sql.hive.thriftserver.SparkSQLCLIDriver --conf spark.abc=123 ``` ``` 99416 org.apache.spark.deploy.SparkSubmit --conf spark.abc=123 --class org.apache.spark.sql.hive.thriftserver.SparkSQLCLIDriver spark-internal ``` ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ https://github.com/apache/kyuubi/actions/runs/6981210739/job/18997901268?pr=5773 ``` - JpsApplicationOperation with spark local mode *** FAILED *** The code passed to eventually never returned normally. Attempted 41 times over 10.235822332 seconds. Last failure message: "23463" did not equal null. (JpsApplicationOperationSuite.scala:92) ``` #### Behavior With This Pull Request 🎉 GA #### Related Unit Tests JpsApplicationOperationSuite "JpsApplicationOperation with spark local mode" --- # Checklists ## 📝 Author Self Checklist - [x] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project - [x] I have performed a self-review - [ ] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) ## 📝 Committer Pre-Merge Checklist - [ ] Pull request title is okay. - [ ] No license issues. - [ ] Milestone correctly set? - [ ] Test coverage is ok - [ ] Assignees are selected. - [ ] Minimum number of approvals - [ ] No changes are requested **Be nice. Be informative.** Closes #5785 from cxzl25/test_jps_local. Closes #5785 bb456a6 [sychen] Fix flaky test - JpsApplicationOperation with spark local mode Authored-by: sychen <sychen@ctrip.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
1 parent 5761e83 commit 19ae399

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

kyuubi-server/src/test/scala/org/apache/kyuubi/engine/JpsApplicationOperationSuite.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,8 @@ class JpsApplicationOperationSuite extends KyuubiFunSuite {
8383
val desc1 = jps.getApplicationInfoByTag(ApplicationManagerInfo(None), id)
8484
assert(desc1.id != null)
8585
assert(desc1.name != null)
86+
assert(!desc1.name.contains("org.apache.spark.launcher.Main"))
87+
assert(desc1.name.contains("org.apache.spark.deploy.SparkSubmit"))
8688
assert(desc1.state == ApplicationState.RUNNING)
8789
val response = jps.killApplicationByTag(ApplicationManagerInfo(None), id)
8890
assert(response._1, response._2)

0 commit comments

Comments
 (0)