MINOR: Fix typo in Sender class comment#21293
Merged
AndrewJSchofield merged 3 commits intoapache:trunkfrom Jan 13, 2026
Merged
Conversation
github-actions
bot
added
triage
david-parkk
changed the title
AndrewJSchofield
requested changes
Jan 12, 2026
Member
AndrewJSchofield
left a comment
AndrewJSchofield
left a comment
There was a problem hiding this comment.
Thanks for the PR. I think the comment could do with a more radical improvement.
| private final Logger log; | ||
|
|
||
| /* the state of each nodes connection */ | ||
| /* the state of each node's connection */ |
Member
There was a problem hiding this comment.
It is missing an apostrophe for sure, but I don't think the comment really describes the field adequately.
Contributor
Author
Thanks for the feedback! I've updated the comment to: "the client for sending requests to the Kafka cluster" |
AndrewJSchofield
approved these changes
Jan 13, 2026
Member
AndrewJSchofield
left a comment
AndrewJSchofield
left a comment
There was a problem hiding this comment.
Thanks for the update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewers: Andrew Schofield aschofield@confluent.io