-
Notifications
You must be signed in to change notification settings - Fork 14.9k
KAFKA-19951: Update lz4 dependency version for CVE-2025-12183 & CVE-2025-66566 #21035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated lz4 dependency version from 1.8.0 to 1.8.1. For https://nvd.nist.gov/vuln/detail/CVE-2025-12183
|
Thanks for the patch. Could you also update |
|
@DL1231 thank you, updated license binary, do you know how |
|
I linked the PR to KAFKA-19951. Regarding the compression level, it's explained in |
|
Also there's still a build issue: |
It looks like there was a recent change to discontinue https://github.com/lz4/lz4-java, in favor of community fork https://github.com/yawkat/lz4-java . I'll try updating to new GAV |
|
Maintainer here. Interesting, did you see that error when depending on org.lz4:lz4-java:1.8.1 directly, without any reference to at.yawk.lz4? Maybe there's something wrong with the gradle capability metadata |
|
Looks like max compression level is unchanged at |
Yeah, had to switch to your gav for it to work (I'm just a random person not affil with apache): 51c520e |
Simple example demonstrating the issue mentioned by @mimaison: If only There might be an issue with the capability configuration together with the relocation settings, which could be the reason for the problem. |
|
@mjschwaiger I made a test case here: https://github.com/yawkat/test-case-gradle-rename-capability I think it's a gradle bug, I've asked on the gradle community slack about it. |
chia7712
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@mimaison do you have time to take a look at this? |
|
BTW: If the Java project is discontinued, I think it would be a good idea to get rid of the library. Not sure where I could raise this question as an issue. |
I recommend KAFKA-17301 for raising this issue 😄 |
gradle/dependencies.gradle
Outdated
| lz4: "1.8.0", | ||
| // https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/record/CompressionType.java#L73-L74 | ||
| // https://github.com/yawkat/lz4-java/blob/main/src/java/net/jpountz/lz4/LZ4Constants.java#L23-L24 | ||
| lz4: "1.8.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we directly bump to 1.10.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done (cd8be9e)
@yawkat I'm not sure that is the right CVE, that one is for oat++ https://nvd.nist.gov/vuln/detail/CVE-2025-6566 . Can you link to the right CVE? |
|
66566, not 6566. It's not on nvd yet i guess |
|
My mistake, misread the number, and when I did search for the new value it gave me the oat one. Looks like second CVE has been published: https://nvd.nist.gov/vuln/detail/CVE-2025-66566 |
|
In the mean time I have contacted Sonatype over email and they have confirmed that they are aware of the relocation and they have been in touch with the previous owners of lz4-java. |
|
@yawkat : Does Sonatype also need to configure relocation for 1.10.1? I still get this error when trying to update my local (Maven) project: In my Gradle projects I can still use the So either Sonatype needs to support relocation or everyone needs to replace the dependency, I suppose? (Thanks for your great work so far, by the way! 🌻 🚀 ) |
|
There will be no relocation for versions past 1.8.1 |
|
Dear all, is it good to go for merging? it would be cool to have your approval 😄 |
|
There's still a mention of |
mimaison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…025-66566 (#21035) Updated lz4 dependency version from 1.8.0 to 1.10.1 ## CVE-2025-12183 https://nvd.nist.gov/vuln/detail/CVE-2025-12183 ## CVE-2025-66566 https://nvd.nist.gov/vuln/detail/CVE-2025-66566 ## Releases https://github.com/yawkat/lz4-java/releases/tag/v1.8.1 https://github.com/yawkat/lz4-java/releases/tag/v1.10.0 https://github.com/yawkat/lz4-java/releases/tag/v1.10.1 Reviewers: Gaurav Narula <gaurav_narula2@apple.com>, Lan Ding <isDing_L@163.com>, Chia-Ping Tsai <chia7712@gmail.com>, Mickael Maison <mimaison@apache.org>, PoAn Yang <payang@apache.org> --------- Co-authored-by: Erik Anderson <erik@Eriks-MacBook-Air-M2.local> Co-authored-by: Chia-Ping Tsai <chia7712@gmail.com> Co-authored-by: Mickael Maison <mickael.maison@gmail.com>
…025-66566 (#21035) Updated lz4 dependency version from 1.8.0 to 1.10.1 https://nvd.nist.gov/vuln/detail/CVE-2025-12183 https://nvd.nist.gov/vuln/detail/CVE-2025-66566 https://github.com/yawkat/lz4-java/releases/tag/v1.8.1 https://github.com/yawkat/lz4-java/releases/tag/v1.10.0 https://github.com/yawkat/lz4-java/releases/tag/v1.10.1 Reviewers: Gaurav Narula <gaurav_narula2@apple.com>, Lan Ding <isDing_L@163.com>, Chia-Ping Tsai <chia7712@gmail.com>, Mickael Maison <mimaison@apache.org>, PoAn Yang <payang@apache.org> --------- Co-authored-by: Erik Anderson <erik@Eriks-MacBook-Air-M2.local> Co-authored-by: Chia-Ping Tsai <chia7712@gmail.com> Co-authored-by: Mickael Maison <mickael.maison@gmail.com>
…025-66566 (#21035) Updated lz4 dependency version from 1.8.0 to 1.10.1 https://nvd.nist.gov/vuln/detail/CVE-2025-12183 https://nvd.nist.gov/vuln/detail/CVE-2025-66566 https://github.com/yawkat/lz4-java/releases/tag/v1.8.1 https://github.com/yawkat/lz4-java/releases/tag/v1.10.0 https://github.com/yawkat/lz4-java/releases/tag/v1.10.1 Reviewers: Gaurav Narula <gaurav_narula2@apple.com>, Lan Ding <isDing_L@163.com>, Chia-Ping Tsai <chia7712@gmail.com>, Mickael Maison <mimaison@apache.org>, PoAn Yang <payang@apache.org> --------- Co-authored-by: Erik Anderson <erik@Eriks-MacBook-Air-M2.local> Co-authored-by: Chia-Ping Tsai <chia7712@gmail.com> Co-authored-by: Mickael Maison <mickael.maison@gmail.com>
…025-66566 (#21035) Updated lz4 dependency version from 1.8.0 to 1.10.1 https://nvd.nist.gov/vuln/detail/CVE-2025-12183 https://nvd.nist.gov/vuln/detail/CVE-2025-66566 https://github.com/yawkat/lz4-java/releases/tag/v1.8.1 https://github.com/yawkat/lz4-java/releases/tag/v1.10.0 https://github.com/yawkat/lz4-java/releases/tag/v1.10.1 Reviewers: Gaurav Narula <gaurav_narula2@apple.com>, Lan Ding <isDing_L@163.com>, Chia-Ping Tsai <chia7712@gmail.com>, Mickael Maison <mimaison@apache.org>, PoAn Yang <payang@apache.org> --------- Co-authored-by: Erik Anderson <erik@Eriks-MacBook-Air-M2.local> Co-authored-by: Chia-Ping Tsai <chia7712@gmail.com> Co-authored-by: Mickael Maison <mickael.maison@gmail.com>
|
@erikanderson Do you have a Jira Id? So I mark you as the author |
|
@mimaison I don't in ASF |
|
@erikanderson If you desire, you can create an account using https://selfserve.apache.org/jira-account.html and I'll assign the Jira to you. This is not required, you will still appear as a contributor in the release notes as they are generated from the commit history. Thanks for your contribution! |
|
I approved your account request and assigned KAFKA-19951 to you. Thanks! |
|
when the release version will be released ? |
…025-66566 (apache#21035) Updated lz4 dependency version from 1.8.0 to 1.10.1 ## CVE-2025-12183 https://nvd.nist.gov/vuln/detail/CVE-2025-12183 ## CVE-2025-66566 https://nvd.nist.gov/vuln/detail/CVE-2025-66566 ## Releases https://github.com/yawkat/lz4-java/releases/tag/v1.8.1 https://github.com/yawkat/lz4-java/releases/tag/v1.10.0 https://github.com/yawkat/lz4-java/releases/tag/v1.10.1 Reviewers: Gaurav Narula <gaurav_narula2@apple.com>, Lan Ding <isDing_L@163.com>, Chia-Ping Tsai <chia7712@gmail.com>, Mickael Maison <mimaison@apache.org>, PoAn Yang <payang@apache.org> --------- Co-authored-by: Erik Anderson <erik@Eriks-MacBook-Air-M2.local> Co-authored-by: Chia-Ping Tsai <chia7712@gmail.com> Co-authored-by: Mickael Maison <mickael.maison@gmail.com>
I'm exactly facing this, struggling to switch this dependency with the new group. But with the gradle capability feature, it works when i define like this: But in my case the problem is, all my consumers of my internal framework (which uses above kafka-clients) are forced to define above logic to make it work, which i didnt like. Hope in newer versions of kafka-clients, they update their dependency graph with new group. |
They already did: #21035 <-- this PR |
Oh yeah.. missed reading entire thread.. but looks like 3.9.2 is not yet released :) |
It's currently in the oven! Stay tuned 😄 |
|
Let’s just hope it’s baking nicely and not getting a little too crispy 😄 |
Updated lz4 dependency version from 1.8.0 to 1.10.1
CVE-2025-12183
https://nvd.nist.gov/vuln/detail/CVE-2025-12183
CVE-2025-66566
https://nvd.nist.gov/vuln/detail/CVE-2025-66566
Releases
https://github.com/yawkat/lz4-java/releases/tag/v1.8.1
https://github.com/yawkat/lz4-java/releases/tag/v1.10.0
https://github.com/yawkat/lz4-java/releases/tag/v1.10.1
Reviewers: Gaurav Narula gaurav_narula2@apple.com, Lan Ding
isDing_L@163.com, Chia-Ping Tsai chia7712@gmail.com, Mickael Maison
mimaison@apache.org, PoAn Yang payang@apache.org