MINOR; Use underscore for variable initialization in Scala sources #12534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! |
|
Sure thing will do. |
mdedetrich
force-pushed
the
kafkaserver-underscore-initialization
branch
from
1481dbd to
b925ce0
Compare
mdedetrich
changed the title
mdedetrich
force-pushed
the
kafkaserver-underscore-initialization
branch
from
b925ce0 to
dd29dce
Compare
|
@mimaison PR has been updated as you wanted. |
mdedetrich
commented
Aug 19, 2022
In Scala its standard practice to use _ whenever you are initializing variables. In regard to implementation, for object references _ initialization maps to null so there is no change in behaviour.
mdedetrich
force-pushed
the
kafkaserver-underscore-initialization
branch
from
dd29dce to
23cce8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Scala its standard practice to use _ whenever you are initializing
variables. In regard to implementation, for object references
_ initialization maps to null so there is no change in behaviour.
This PR is the equivalent of #12471 but for KafkaServer