You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
/** * Save cluster tag. * * @param request cluster tag * @param operator name of operator * @return cluster tag id after saving */IntegersaveTag(ClusterTagRequestrequest, Stringoperator);
/** * Save cluster tag. * * @param request cluster tag * @param opInfo userinfo of operator * @return cluster tag id after saving */IntegersaveTag(ClusterTagRequestrequest, UserInfoopInfo);
The only difference is the last parameter, one is operator and the other is opInfo.
The opInfo is used to obtain the name operator, so we can say these two interfaces are the same.
There are some problems with this implementation:
code duplication, there are many redundant codes now
hard to maintain, we have to change both places when updating, if only change one interface, these two interfaces are out of consistency which we already have now
So, it's better to remove the duplicated code and keep consistency for InLong-API and InLong-OpenAPI.
Description
In manager-service module, there are many duplicated interfaces for API and open API.
e.g.
https://github.com/apache/inlong/blob/master/inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/cluster/InlongClusterService.java#L46~L62
The only difference is the last parameter, one is
operator
and the other isopInfo
.The
opInfo
is used to obtain the nameoperator
, so we can say these two interfaces are the same.There are some problems with this implementation:
So, it's better to remove the duplicated code and keep consistency for InLong-API and InLong-OpenAPI.
InLong Component
InLong Manager
Are you willing to submit PR?
Code of Conduct
The text was updated successfully, but these errors were encountered: