Skip to content

Conversation

@rahil-c
Copy link
Contributor

@rahil-c rahil-c commented May 12, 2025

What is the purpose of the pull request

This pr aims to add integration tests which test the XTable REST Service for combinations of all table formats, for both partitioned and unpartitioned tables.

Special Note

Brief change log

Adds an IT Test for conversion service.

Verify this pull request

Ran the IT test locally which passes (see screenshot)
Screenshot 2025-05-28 at 9 45 05 PM

@rahil-c
Copy link
Contributor Author

rahil-c commented May 29, 2025

Unsure why the IT itself is flaky on the CI as it passes fine locally.

Screenshot 2025-05-29 at 1 14 20 AM

@rahil-c rahil-c changed the title Add intial IT test for XTable REST Service Add intial IT for XTable REST Service May 29, 2025
Copy link
Contributor

@vinishjail97 vinishjail97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahil-c Can you rebase with the latest main? I can merge after that.

@vinishjail97
Copy link
Contributor

Error: ITConversionService.testVariousOperations(String, boolean)[1] » Spark Job aborted due to stage failure: Task 0 in stage 36.0 failed 1 times, most recent failure: Lost task 0.0 in stage 36.0 (TID 104) (fv-az1983-640.xojnruca2udebm2tjfdy52k3le.bx.internal.cloudapp.net executor driver): scala.MatchError: TimestampNTZType (of class org.apache.spark.sql.types.TimestampNTZType$)

Is this passing locally?

@rahil-c
Copy link
Contributor Author

rahil-c commented Jun 24, 2025

Screenshot 2025-06-24 at 4 20 00 PM

Put a fix again, ran the test locally passing, hoping CI passes.

@rahil-c
Copy link
Contributor Author

rahil-c commented Jun 25, 2025

CI did not fail for an error but it seemed like it was canceled?

I also ran from my local terminal instead of intellij mvn clean test -Dtest=ITConversionService and seems test pass fine, so wondering if we can retrigger the run for this?



INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.xtable.service.ITConversionService
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.apache.spark.unsafe.Platform (file:/Users/rahil/.m2/repository/org/apache/spark/spark-unsafe_2.12/3.4.2/spark-unsafe_2.12-3.4.2.jar) to constructor java.nio.DirectByteBuffer(long,int)
WARNING: Please consider reporting this to the maintainers of org.apache.spark.unsafe.Platform
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 102.1 s -- in org.apache.xtable.service.ITConversionService
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- surefire:3.3.0:test (default) @ xtable-service ---
[INFO] Skipping execution of surefire because it has already been run for this configuration
[INFO] Saved Build to local file: /Users/rahil/.m2/build-cache/v1/org.apache.xtable/xtable-service/d9e9c1b952afb9bc/local/buildinfo.xml
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:51 min
[INFO] Finished at: 2025-06-24T17:37:15-07:00
[INFO] ------------------------------------------------------------------------
 rahil@mac  ~/workplace/incubator-xtable/xtable-service   integ-tests 

@rahil-c
Copy link
Contributor Author

rahil-c commented Jun 25, 2025

@vinishjail97 can you merge this when you get a chance ci passes.

@vinishjail97 vinishjail97 merged commit 19cbda4 into apache:main Jun 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants