Skip to content
This repository was archived by the owner on Jun 3, 2021. It is now read-only.

Commit a82d685

Browse files
committed
[Android]avoid to call setViewPort repeatedly
1 parent 76bfd6b commit a82d685

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -452,9 +452,15 @@ public void setUseScroller(boolean use) {
452452
}
453453

454454
public void setInstanceViewPortWidth(int instanceViewPortWidth) {
455+
setInstanceViewPortWidth(instanceViewPortWidth,false);
456+
457+
}
458+
public void setInstanceViewPortWidth(int instanceViewPortWidth,boolean fromMetaModule){
455459
this.mInstanceViewPortWidth = instanceViewPortWidth;
456460
this.mAutoAdjustDeviceWidth = false;
457-
WXBridgeManager.getInstance().setViewPortWidth(getInstanceId(),mInstanceViewPortWidth);
461+
if(!fromMetaModule){
462+
WXBridgeManager.getInstance().setViewPortWidth(getInstanceId(), mInstanceViewPortWidth);
463+
}
458464
}
459465

460466
public void setAutoAdjustDeviceWidth(boolean autoAdjustViewPort){

android/sdk/src/main/java/com/taobao/weex/ui/module/WXMetaModule.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,12 @@ public void setViewport(String param) {
6060
// todo maybe getString(WIDTH) is "device-height"
6161
if (DEVICE_WIDTH.endsWith(jsObj.getString(WIDTH))) {
6262
int width = (int)(WXViewUtils.getScreenWidth(cxt)/WXViewUtils.getScreenDensity(cxt));
63-
mWXSDKInstance.setInstanceViewPortWidth(width);
63+
mWXSDKInstance.setInstanceViewPortWidth(width,true);
6464
WXLogUtils.d("[WXMetaModule] setViewport success[device-width]=" + width);
6565
} else {
6666
int width = jsObj.getInteger(WIDTH);
6767
if (width > 0) {
68-
mWXSDKInstance.setInstanceViewPortWidth(width);
68+
mWXSDKInstance.setInstanceViewPortWidth(width,true);
6969
}
7070
WXLogUtils.d("[WXMetaModule] setViewport success[width]=" + width);
7171
}

0 commit comments

Comments
 (0)