Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Improve Netty's documentation #1383

Closed
3 tasks done
rickyma opened this issue Dec 19, 2023 · 0 comments · Fixed by #1384
Closed
3 tasks done

[DOCS] Improve Netty's documentation #1383

rickyma opened this issue Dec 19, 2023 · 0 comments · Fixed by #1384

Comments

@rickyma
Copy link
Contributor

rickyma commented Dec 19, 2023

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Which parts of the documentation do you think need improvement?

After #1349, we can only enable Netty by setting at least two parameters: rss.server.netty.port and rss.rpc.server.type. The documentation needs to be updated. Also, Netty should be capitalized.

Affects Version(s)

master

Improving the documentation

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
rickyma added a commit to rickyma/incubator-uniffle that referenced this issue Dec 19, 2023
@jerqi jerqi linked a pull request Dec 19, 2023 that will close this issue
jerqi pushed a commit that referenced this issue Dec 19, 2023
### What changes were proposed in this pull request?

Improve Netty's documentation. (Add the parameter `rss.rpc.server.type` and change all "Netty" to uppercase.)

### Why are the changes needed?

For [#1383](#1383)

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

No need to be tested.
zuston pushed a commit to zuston/incubator-uniffle that referenced this issue Jan 18, 2024
### What changes were proposed in this pull request?

Improve Netty's documentation. (Add the parameter `rss.rpc.server.type` and change all "Netty" to uppercase.)

### Why are the changes needed?

For [apache#1383](apache#1383)

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

No need to be tested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant