-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Improve Netty's documentation #1383
Comments
rickyma
added a commit
to rickyma/incubator-uniffle
that referenced
this issue
Dec 19, 2023
jerqi
pushed a commit
that referenced
this issue
Dec 19, 2023
### What changes were proposed in this pull request? Improve Netty's documentation. (Add the parameter `rss.rpc.server.type` and change all "Netty" to uppercase.) ### Why are the changes needed? For [#1383](#1383) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No need to be tested.
zuston
pushed a commit
to zuston/incubator-uniffle
that referenced
this issue
Jan 18, 2024
### What changes were proposed in this pull request? Improve Netty's documentation. (Add the parameter `rss.rpc.server.type` and change all "Netty" to uppercase.) ### Why are the changes needed? For [apache#1383](apache#1383) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No need to be tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Code of Conduct
Search before asking
Which parts of the documentation do you think need improvement?
After #1349, we can only enable Netty by setting at least two parameters:
rss.server.netty.port
andrss.rpc.server.type
. The documentation needs to be updated. Also, Netty should be capitalized.Affects Version(s)
master
Improving the documentation
No response
Anything else
No response
Are you willing to submit PR?
The text was updated successfully, but these errors were encountered: