Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: fix npmjs conflicts #6793

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

slievrly
Copy link
Member

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

fix npmjs conficts

Ⅱ. Does this pull request fix one issue?

fix #6792

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@slievrly slievrly changed the title optimize: fix npmjs conficts optimize: fix npmjs conflicts Aug 28, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.20%. Comparing base (dadaa6b) to head (e734540).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6793      +/-   ##
============================================
+ Coverage     52.18%   52.20%   +0.01%     
- Complexity     6291     6295       +4     
============================================
  Files          1065     1065              
  Lines         37193    37193              
  Branches       4413     4411       -2     
============================================
+ Hits          19410    19416       +6     
+ Misses        15865    15860       -5     
+ Partials       1918     1917       -1     

see 4 files with indirect coverage changes

@funky-eyes funky-eyes merged commit 9483430 into apache:2.x Aug 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npmjs conflict
2 participants