Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: init namingserver client #6536

Merged
merged 40 commits into from
Aug 13, 2024
Merged

Conversation

ggbocoder
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Seata client for invoking the Naming Server

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 7.32394% with 329 lines in your changes missing coverage. Please review.

Project coverage is 50.53%. Comparing base (fff45ce) to head (18d3db4).
Report is 94 commits behind head on 2.x.

Files with missing lines Patch % Lines
.../namingserver/NamingserverRegistryServiceImpl.java 0.00% 237 Missing ⚠️
...in/java/org/apache/seata/common/metadata/Node.java 14.28% 26 Missing and 4 partials ⚠️
.../src/main/java/org/apache/seata/server/Server.java 10.00% 17 Missing and 1 partial ⚠️
...a/org/apache/seata/common/util/HttpClientUtil.java 38.09% 13 Missing ⚠️
...e/seata/common/metadata/namingserver/Instance.java 50.00% 7 Missing ⚠️
...common/metadata/namingserver/NamingServerNode.java 33.33% 6 Missing ⚠️
...registry/namingserver/NamingRegistryException.java 0.00% 6 Missing ⚠️
...pache/seata/common/metadata/namingserver/Unit.java 0.00% 4 Missing ⚠️
.../apache/seata/discovery/registry/RegistryType.java 0.00% 2 Missing ⚠️
...try/namingserver/NamingserverRegistryProvider.java 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6536      +/-   ##
============================================
- Coverage     50.99%   50.53%   -0.46%     
- Complexity     5923     5926       +3     
============================================
  Files          1058     1061       +3     
  Lines         36779    37082     +303     
  Branches       4369     4399      +30     
============================================
- Hits          18754    18738      -16     
- Misses        16131    16445     +314     
- Partials       1894     1899       +5     
Files with missing lines Coverage Δ
...mon/src/main/java/org/apache/seata/common/XID.java 92.30% <ø> (ø)
...he/seata/namingserver/entity/pojo/ClusterData.java 63.79% <100.00%> (ø)
.../apache/seata/discovery/registry/RegistryType.java 0.00% <0.00%> (ø)
...try/namingserver/NamingserverRegistryProvider.java 0.00% <0.00%> (ø)
...eata/namingserver/controller/NamingController.java 37.83% <0.00%> (-1.06%) ⬇️
...ache/seata/namingserver/manager/NamingManager.java 59.13% <0.00%> (ø)
...pache/seata/common/metadata/namingserver/Unit.java 0.00% <0.00%> (ø)
...common/metadata/namingserver/NamingServerNode.java 37.03% <33.33%> (+17.80%) ⬆️
...registry/namingserver/NamingRegistryException.java 0.00% <0.00%> (ø)
...e/seata/common/metadata/namingserver/Instance.java 41.79% <50.00%> (-1.07%) ⬇️
... and 4 more

... and 9 files with indirect coverage changes

@funky-eyes funky-eyes added this to the 2.2.0 milestone Jul 10, 2024
@funky-eyes funky-eyes added type: feature Category issues or prs related to feature request. module/discovery discovery module labels Jul 10, 2024
@funky-eyes funky-eyes changed the title feature:init namingserver client feature: init namingserver client Aug 13, 2024
funky-eyes and others added 3 commits August 13, 2024 23:43
…e/seata/discovery/registry/namingserver/NamingserverRegistryServiceImplTest.java
…e/seata/discovery/registry/namingserver/NamingserverRegistryServiceImplTest.java
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 1171548 into apache:2.x Aug 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/discovery discovery module multilingual type: feature Category issues or prs related to feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants